nixos/sourcehut: refactor according to coding standards#267900
Merged
AndersonTorres merged 3 commits intoNixOS:masterfrom Nov 27, 2023
Merged
nixos/sourcehut: refactor according to coding standards#267900AndersonTorres merged 3 commits intoNixOS:masterfrom
AndersonTorres merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
christoph-heiss
approved these changes
Nov 17, 2023
delroth
added
the
12.approvals: 1
AndersonTorres
previously approved these changes
Nov 26, 2023
Member
AndersonTorres
left a comment
AndersonTorres
left a comment
There was a problem hiding this comment.
Ping me after 24h to merge.
Member
|
@nessdoor please rebase |
Inherit library attributes at a finer granularity, instead.
nessdoor
force-pushed
the
nixos/sourcehut-refactor
branch
from
9009340 to
cbc937c
Compare
christoph-heiss
approved these changes
Nov 27, 2023
Contributor
Author
|
@AndersonTorres sorry for coming back after all this time, but: is it me or the first commit of this PR didn't get merged? |
Member
|
Why? There is no "partial merge" on github interface... |
Contributor
Author
|
Sure, actually it was my bad, sorry. Just noticed that the reformatting of an entire file ( Sorry to have troubled you, I will amend my mistake in the future. |
Contributor
|
@nessdoor @AndersonTorres thank you both for the continued maintenance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Just a light refactor aimed at:
with lib;expressions, which are the target of a tree-wide refactoring campaign (see Tracking issue: remove overuses ofwith lib;#208242);nixpkgs-fmt.Consider this a prerequisite for more profound and thoughtful refactoring to come in the near future, as this module is bound to be modified following the discussion in #245394.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)