Skip to content

Comments

NSPlist: fix build with clang 16#267803

Merged
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:nsplist-fix
Nov 16, 2023
Merged

NSPlist: fix build with clang 16#267803
wegank merged 1 commit intoNixOS:masterfrom
reckenrode:nsplist-fix

Conversation

@reckenrode
Copy link
Contributor

Description of changes

Fixes build failure on staging-next #263535: https://hydra.nixos.org/build/240518841

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The pre-generated lexer uses the `register` storage class specifier,
which is not supported in C++17 (the default for clang 16). Regenerate
it for improved compatibility.
@ofborg ofborg bot requested a review from matthewbauer November 16, 2023 04:36
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 16, 2023
@vcunat vcunat changed the base branch from staging-next to master November 16, 2023 21:08
@wegank
Copy link
Member

wegank commented Nov 16, 2023

Result of nixpkgs-review pr 267803 run on aarch64-darwin 1

3 packages built:
  • NSPlist
  • PlistCpp
  • xib2nib

@wegank wegank merged commit 17f8c17 into NixOS:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants