Skip to content

Comments

[staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match#267684

Merged
RaitoBezarius merged 1 commit intoNixOS:staging-nextfrom
lilyinstarlight:fix/pymupdf-python-version-oopsy
Nov 16, 2023
Merged

[staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match#267684
RaitoBezarius merged 1 commit intoNixOS:staging-nextfrom
lilyinstarlight:fix/pymupdf-python-version-oopsy

Conversation

@lilyinstarlight
Copy link
Member

Description of changes

Fixes broken python310Packages.pymupdf build on Hydra: https://hydra.nixos.org/build/240865389

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lilyinstarlight lilyinstarlight changed the title [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure they are build with the same python as pymupdf [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure python version match Nov 15, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 15, 2023
@lilyinstarlight lilyinstarlight changed the title [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure python version match [staging-next] python310Packages.pymupdf: override mupdf python bindings version to ensure match Nov 15, 2023
@lilyinstarlight lilyinstarlight force-pushed the fix/pymupdf-python-version-oopsy branch from f389372 to f9ecb35 Compare November 15, 2023 15:01
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 15, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 15, 2023
@ofborg ofborg bot requested a review from teto November 15, 2023 16:03
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 15, 2023
@RaitoBezarius RaitoBezarius merged commit 9387784 into NixOS:staging-next Nov 16, 2023
@lilyinstarlight lilyinstarlight deleted the fix/pymupdf-python-version-oopsy branch November 16, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants