sourcehut.pastesrht: add missing backend component#267538
Merged
tomberek merged 3 commits intoNixOS:masterfrom Nov 28, 2023
Merged
sourcehut.pastesrht: add missing backend component#267538tomberek merged 3 commits intoNixOS:masterfrom
tomberek merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
nessdoor
force-pushed
the
pkgs/paste.sr.ht
branch
from
450f71f to
d84b211
Compare
ofborg
bot
added
11.by: package-maintainer
Contributor
|
LGTM, I'll smoke-test it in the next few days if needed. Result of 2 packages blacklisted:
2 packages built:
|
Contributor
|
Just spun up a paste.sr.ht instance, seems fine. 👍 |
christoph-heiss
approved these changes
Nov 28, 2023
1 task
Contributor
|
Successfully created backport PR for |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The
pasteservice has a backend component (pastesrht-api) like many other Sourcehut services, but this had been omitted from its derivation in Nixpkgs, resulting in a malfunctioning service. This PR compiles the missing component and integrates it into the NixOS module. In addition,pastehas been updated to the latest patch level, from0.15.1to0.15.2.This is a follow-up PR to #245394 (comment), part of an ongoing series of PRs stemming from the fixes and improvements identified while testing the modifications brought by #245394.
Unfortunately, the Sourcehut module suffers from a scarcity of automated integration tests, so all functionalities have been tested by hand on a server running a complete Sourcehut instance. A more comprehensive battery of tests for all Sourcehut components will be added in a future PR.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)