Skip to content

qt5.qtwebkit: update dependencies#267514

Closed
eryngion wants to merge 2 commits intoNixOS:masterfrom
eryngion:use-hyphen-from-pkgs
Closed

qt5.qtwebkit: update dependencies#267514
eryngion wants to merge 2 commits intoNixOS:masterfrom
eryngion:use-hyphen-from-pkgs

Conversation

@eryngion
Copy link

@eryngion eryngion commented Nov 14, 2023

hyphen: the sources in tarbals are identical, and hyphen from pkgs properly supports cross compilation.
woff2: qtwebkit will use the bundled woff2 lib if we don't provide a system one
dwz: "DWARF optimization and duplicate removal tool" is just nice to have, I guess

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@eryngion eryngion requested a review from ttuegel as a code owner November 14, 2023 19:03
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Nov 14, 2023
@ofborg ofborg bot requested review from abbradar and periklis November 14, 2023 20:37
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 14, 2023
@Artturin
Copy link
Member

Artturin commented Nov 22, 2023

@ofborg build qt5.qtwebkit

Use the attr path as the commit title, then ofborg will build it https://github.com/NixOS/ofborg#automatic-building

@Artturin Artturin changed the title qtwebkit: use hyphen from pkgs qt5.qtwebkit: use hyphen from pkgs Nov 22, 2023
@eryngion eryngion changed the title qt5.qtwebkit: use hyphen from pkgs qt5.qtwebkit: update dependencies Nov 23, 2023
@eryngion
Copy link
Author

Welp, in the meantime some scope creep happened.

@Artturin
Copy link
Member

Use the attr path as the commit title, then ofborg will build it https://github.com/NixOS/ofborg#automatic-building

eryngion added 2 commits November 23, 2023 16:11
The sources in tarbals are identical, and hyphen from pkgs properly supports cross compilation.
It will use the bundled woff2 lib if we don't provide a system one.
And "DWARF optimization and duplicate removal tool" is just nice to
have, I guess.
@eryngion eryngion force-pushed the use-hyphen-from-pkgs branch from 91037b9 to 4261eb7 Compare November 23, 2023 13:12
@eryngion
Copy link
Author

eryngion commented Nov 23, 2023

Oh, thanks for repeating, my attention is a bit flaky. I've updated commit titles and rebased on the current master.

@eryngion
Copy link
Author

Speaking of lack of attention, dwz probably doesn't do us any good here.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 25, 2025
@eryngion
Copy link
Author

eryngion commented Feb 5, 2026

Superseded by #487372.

@eryngion eryngion closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants