Skip to content

fix mkpasswd: use the git repository#2673

Closed
cstrahan wants to merge 1 commit intoNixOS:masterfrom
cstrahan:mkpasswd-fix
Closed

fix mkpasswd: use the git repository#2673
cstrahan wants to merge 1 commit intoNixOS:masterfrom
cstrahan:mkpasswd-fix

Conversation

@cstrahan
Copy link
Contributor

This fixes the mkpasswd package. Debian removed v5.1.1 from their FTP server, so this uses the official git repo instead.

@cstrahan
Copy link
Contributor Author

What would it take to get this into the 14.04 stable channel (and on a new ISO image)? Installing NixOS from the minimal ISO is currently impossible (without first providing a package override) until this is resolved.

@CMCDragonkai
Copy link
Member

5.1.2 doesn't work? Maybe we could tell the debian maintainers about this problem?

@cstrahan
Copy link
Contributor Author

@CMCDragonkai: 5.1.2 doesn't work? Maybe we could tell the debian maintainers about this problem?

I was mistaken; the problem I was experiencing is detailed in #2675. It should be safe to try bumping this up to v5.1.2. However, I'd rather not do that just yet, in case there are any unforeseen problems with the latest version. Instead, I'd rather fix the immediate problem of being unable to install NixOS due to the whois maintainer occasionally removing the sources from the FTP site (note that there are only a couple versions listed on the FTP site, while there are 92 revisions listed on GitHub...).

@CMCDragonkai
Copy link
Member

Ping @thoughtpolice @vcunat

@thoughtpolice
Copy link
Member

Merged into master in e5eed8f; merged into release-14.04 in ce13d17 - thanks!

@thoughtpolice
Copy link
Member

Also, I'll just note that this fix should propagate automatically - soon, Hydra will pick up the changesets for both master and release-14.04, and it will build and push out new ISOs. So now we just need to wait a little while and it should be fine.

@CMCDragonkai
Copy link
Member

Oh this is still using 5.1.1 then? Not the new 5.1.2. Because with this fixed #2675 that should mean 5.1.2 is good too. But it is not a big deal.

@CMCDragonkai
Copy link
Member

@thoughtpolice @cstrahan How do we get the new package index from the current release 14.04? I just downloaded the most recent distribution, and still the same error.

Do I have to use the unstable nixos or unstable nixpkgs?

This PR has been reverted.

@vcunat
Copy link
Member

vcunat commented May 22, 2014

The function fetchFromGitHub is not in release yet. The same holds for other functions related to unstable downloads (fetchpatch, fetchzip). This state really complicates porting similar simple fixes to release.

Therefore, I suggest we port all those functions, including the state of fetchurl as in current master. I can do it myself. That shouldn't even change any hashes by itself (!), so I think it's safe. Do you agree, @edolstra and others?

@edolstra
Copy link
Member

Backporting is fine, but in the meantime I've added the whois tarball to the tarballs mirror, so it should now work:

$ nix-build -A mkpasswd.src
these derivations will be built:
  /nix/store/ysgg68pnslv6iq60m36xmpwwgw1w4h19-whois_5.1.1.tar.xz.drv
building path(s) `/nix/store/1iphd9dcnb4ddigh1vln2hbxy56y0s82-whois_5.1.1.tar.xz'

trying http://tarballs.nixos.org/sha256/0i06a9mb9qcq272782mg6dffv3k7bqkw4cdr31yrc0s6jqylryv9
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 73832  100 73832    0     0   677k      0 --:--:-- --:--:-- --:--:--  680k
/nix/store/1iphd9dcnb4ddigh1vln2hbxy56y0s82-whois_5.1.1.tar.xz

@vcunat
Copy link
Member

vcunat commented May 22, 2014

Good. I'll attempt it then, perhaps this evening.

@CMCDragonkai
Copy link
Member

@edolstra Do you mean it will work now with the latest builds on the release channel? Or do I have to update to the unstable of nixpkgs?

@cstrahan
Copy link
Contributor Author

@vcunat Awesome - thanks for taking that on (the backporting, that is). If you find that you can't find time, feel free to pass me the baton.

@vcunat
Copy link
Member

vcunat commented May 24, 2014

All pushed now.

@CMCDragonkai
Copy link
Member

@vcunat do I have download a whole new ISO, or can I just update the nixpkgs channel?

@vcunat
Copy link
Member

vcunat commented May 25, 2014

Updating channel will be enough, of course :-) But the change isn't in the default channel yet. Thanks to @edolstra workaround you shouldn't have any problem without any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants