Skip to content

python-modules/protobuf: fix darwin build by passing C++ includes exp… #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LnL7 merged 1 commit into from
Jun 21, 2017
Merged

python-modules/protobuf: fix darwin build by passing C++ includes exp… #26709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkgs/development/python-modules/protobuf.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, python, buildPythonPackage
, protobuf, google_apputils, pyext
, protobuf, google_apputils, pyext, libcxx
, disabled, doCheck ? true }:

with stdenv.lib;
Expand All @@ -8,6 +8,9 @@ buildPythonPackage rec {
inherit (protobuf) name src;
inherit disabled doCheck;

# work around python distutils compiling C++ with $CC
NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin "-I${libcxx}/include/c++/v1";
Copy link
Member

@matthewbauer matthewbauer Jul 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have hit this in a few places now (and this does indeed fix it). But, this is so weird that it only happens on Darwin. Could it be an LLVM thing? Maybe we could do this globally in LLVM's flags so that we don't have to hack around it so much.

/cc @LnL7 @Ericson2314

Copy link
Member

@LnL7 LnL7 Jul 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works because stdc++ and gcc are in the same package, so it knows where to look as a fallback if the stdenv doesn't add it explicitly because $CC is used. On darwin (and any other clangStdenv) libcxx and clang are separate packages, so even if clang has the same fallback it won't find anything on it's own.

But I'm not sure how this relates to #19585, I'd expect that one would be enough. (#42074 (comment))


propagatedBuildInputs = [ protobuf google_apputils ];
buildInputs = [ google_apputils pyext ];

Expand Down