Skip to content

himitsu: 0.3 -> 0.4#267060

Merged
pbsds merged 1 commit intoNixOS:masterfrom
patwid:feat/himitsu-update-v0.4
Nov 30, 2023
Merged

himitsu: 0.3 -> 0.4#267060
pbsds merged 1 commit intoNixOS:masterfrom
patwid:feat/himitsu-update-v0.4

Conversation

@patwid
Copy link
Contributor

@patwid patwid commented Nov 12, 2023

Description of changes

Changelog

Related to: #266456

After applying the patch from #266456 [1], the package can be built:
$ nix run nixpkgs#nixpkgs-review -- rev HEAD
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 12 (delta 3), reused 3 (delta 0), pack-reused 0
Unpacking objects: 100% (12/12), 17.25 KiB | 321.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   e94bccefd06..54da2986be0  master     -> refs/nixpkgs-review/0
$ git worktree add /home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/nixpkgs 54da2986be07ad2ffbade0b3cefaf7f0c2553c88
Preparing worktree (detached HEAD 54da2986be0)
Updating files: 100% (37989/37989), done.
HEAD is now at 54da2986be0 Merge pull request #266989 from r-ryantm/auto-update/linux-wifi-hotspot
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/nixpkgs nixpkgs-overlays=/tmp/tmpy8nfjsgn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 337b7fd01db98c65f17191efd954646ab2e8a05f
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/nixpkgs nixpkgs-overlays=/tmp/tmpy8nfjsgn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
4 packages updated:
harePackages.hare (2023-04-23 → 2023-10-23) harePackages.harec (2023-04-25 → 2023-10-22) himitsu (0.3 → 0.4) himitsu-firefox

$ nix build --nix-path nixpkgs=/home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/nixpkgs nixpkgs-overlays=/tmp/tmpy8nfjsgn --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed -f /home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/build.nix
1 package marked as broken and skipped:
himitsu-firefox

3 packages built:
harePackages.hare harePackages.harec himitsu

$ /nix/store/11glc2yk4jmycvk42q6kikpdcpbnbf6w-nix-2.17.1/bin/nix-shell /home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/shell.nix --nix-path nixpkgs=/home/patwid/.cache/nixpkgs-review/rev-337b7fd01db98c65f17191efd954646ab2e8a05f/nixpkgs nixpkgs-overlays=/tmp/tmpy8nfjsgn

[1] https://github.com/NixOS/nixpkgs/commit/f9b3fbfdf931341961677234b4b888378bcaf7b0.diff

Things done

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • Fits CONTRIBUTING.md.

@patwid patwid marked this pull request as draft November 12, 2023 14:25
@ofborg ofborg bot requested a review from auchter November 12, 2023 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 12, 2023
@onemoresuza
Copy link
Contributor

@patwid, this PR may be rebased against master and marked as ready to review:
the PR for updating hare was merged.

@patwid patwid force-pushed the feat/himitsu-update-v0.4 branch from 4f7e5d8 to 8fb0991 Compare November 29, 2023 17:20
@patwid patwid marked this pull request as ready for review November 29, 2023 17:24
@pbsds
Copy link
Member

pbsds commented Nov 30, 2023

Result of nixpkgs-review pr 267060 run on x86_64-linux 1

1 package marked as broken and skipped:
  • himitsu-firefox
1 package built:
  • himitsu

@pbsds pbsds merged commit c74cc3c into NixOS:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants