Skip to content

ppl: fix build with clang 16#266753

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
wegank:ppl-clang-16
Nov 15, 2023
Merged

ppl: fix build with clang 16#266753
vcunat merged 1 commit intoNixOS:staging-nextfrom
wegank:ppl-clang-16

Conversation

@wegank
Copy link
Copy Markdown
Member

@wegank wegank commented Nov 11, 2023

Description of changes

Doing a proper fix, since setting env.CXXFLAGS = "-std=c++14" will break jasmin-compiler.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 11, 2023
@wegank
Copy link
Copy Markdown
Member Author

wegank commented Nov 11, 2023

Result of nixpkgs-review pr 266753 run on aarch64-darwin 1

1 package failed to build:
  • framac
11 packages built:
  • cloogppl
  • jasmin-compiler
  • jasmin-compiler.bin
  • jasmin-compiler.lib
  • ppl
  • python310Packages.pplpy
  • python310Packages.pplpy.dist
  • python310Packages.pplpy.doc
  • python311Packages.pplpy
  • python311Packages.pplpy.dist
  • python311Packages.pplpy.doc

@vcunat vcunat merged commit 9297b62 into NixOS:staging-next Nov 15, 2023
@wegank wegank deleted the ppl-clang-16 branch November 16, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants