Open
Conversation
Member
|
Where did this turn up to be necessary? |
Member
Author
|
I think it was a solution to a problem with two solutions - one being this PR and the other one being: The original problem was in a private repo, but if I recall correctly, as it relies on reflection. |
infinisil
approved these changes
Dec 15, 2023
Member
infinisil
left a comment
There was a problem hiding this comment.
Minor suggestions, looks fine overall!
13 tasks
Member
|
Recently found myself in want of this, but it looks like this PR was abandoned. Any interest in reviving it, or should I open a new one? |
I'm not a big fan of function reflection, or types.anything, because both are broken concepts, but this at least fixes the use case where a function is expected and passed to, say, callPackage or evalModules, etc. I have chosen not to apply this change to functionTo, because this solution has a performance cost, and perhaps usages of functionTo are better - by not using reflection.
4521b4f to
78d4dcf
Compare
Member
Author
|
Rebased, applied suggestions, tests pass locally. Can be merged if ofborg agrees. EDIT: ignore nixfmt, because types.nix wasn't formatted |
qweered
approved these changes
Sep 28, 2025
Contributor
|
Needs rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Make function reflection work even when
types.anythingmediates the value.I'm not a big fan of function reflection, or types.anything, because both are broken concepts, but this at least fixes the use case where a function is expected and passed to, say,
callPackageorevalModules, etc.I have chosen not to apply this change to
functionTo, because this solution has a performance cost, and perhaps usages offunctionToare better - by not using reflection.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)