Skip to content

Comments

pythonPackages.gensim: init at 2.1.0#26525

Merged
FRidh merged 4 commits intoNixOS:masterfrom
jyp:boto-2.47
Jun 15, 2017
Merged

pythonPackages.gensim: init at 2.1.0#26525
FRidh merged 4 commits intoNixOS:masterfrom
jyp:boto-2.47

Conversation

@jyp
Copy link
Contributor

@jyp jyp commented Jun 12, 2017

Motivation for this change

Adding the gensim library to python packages

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. see the header and the docs; expressions are supposed to be in pkgs/development/python-modules/<package/default.nix.
  2. if you disable tests, always leave a comment explaining why.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you also going to maintain these expressions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licenses.asl20?

@FRidh FRidh added 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package and removed 6.topic: printing Drivers, CUPS & Co. labels Jun 12, 2017
@jyp jyp force-pushed the boto-2.47 branch 5 times, most recently from 758d35d to 4ffc434 Compare June 12, 2017 16:32
@FRidh FRidh merged commit 2a24fda into NixOS:master Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants