hermit-fb: init at 0-unstable-2024-05-01#265212
Draft
MatthewCroughan wants to merge 1 commit intoNixOS:masterfrom
Draft
hermit-fb: init at 0-unstable-2024-05-01#265212MatthewCroughan wants to merge 1 commit intoNixOS:masterfrom
MatthewCroughan wants to merge 1 commit intoNixOS:masterfrom
Conversation
227ac1a to
e49365a
Compare
Contributor
Author
|
|
Member
|
Superseeding #212278 |
JulienMalka
reviewed
Nov 3, 2023
Member
There was a problem hiding this comment.
Can we change this to a one line description, eventually having the complete one in longDescription ?
7e8a325 to
7d16666
Compare
FliegendeWurst
requested changes
Nov 17, 2024
| homepage = "https://github.com/facebookexperimental/hermit.git"; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ matthewcroughan ]; | ||
| mainProgram = "hermit"; |
Member
There was a problem hiding this comment.
Suggested change
| mainProgram = "hermit"; | |
| mainProgram = "hermit"; | |
| platforms = [ "x86_64-linux" ]; |
| ln -s ${./Cargo.lock} Cargo.lock | ||
| ''; | ||
|
|
||
| RUSTC_BOOTSTRAP=1; |
Member
There was a problem hiding this comment.
Suggested change
| RUSTC_BOOTSTRAP=1; | |
| env.RUSTC_BOOTSTRAP = 1; |
| @@ -0,0 +1,52 @@ | |||
| { lib | |||
| , rustPlatform | |||
Member
There was a problem hiding this comment.
Please format with the new formatter.
| hash = "sha256-uzOczLGGSaAILwaDh0WKgs/JeMo3B6tOkNhEIhtBORQ="; | ||
| }; | ||
|
|
||
| cargoLock = { |
Member
There was a problem hiding this comment.
Now that #349360 is available, there is no need to copy the lockfile here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds
hermitfrom Facebook to nixpkgs. I have named ithermit-fbdue to a naming clash with thehermitfont.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)