qt5.qtbase: ignore hook propagated from buildPlatform

[ghost]

Includes

• qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated #220518

Description of changes

The main headache with cross-compiling QT is that our QT derivations go bananas with propagatedInputs. Unfortunately this means that both buildPackages.qtbase and pkgs.qtbase get propagated into the dependencies of every cross-compiled build, which triggers the hook check:

nixpkgs/pkgs/development/libraries/qt-5/hooks/qtbase-setup-hook.sh

Lines 1 to 9 in feaa219

	if [[ -n "${__nix_qtbase-}" ]]; then
	# Throw an error if a different version of Qt was already set up.
	if [[ "$__nix_qtbase" != "@dev@" ]]; then
	echo >&2 "Error: detected mismatched Qt dependencies:"
	echo >&2 " @dev@"
	echo >&2 " $__nix_qtbase"
	exit 1
	fi
	else # Only set up Qt once.

Previously in #227900 I simply disabled the check outright for cross-compiled builds. This is a more refined solution, where we skip the hook if has a different stdenv.outPath than the derivation being built.

This works because the outpath of stdenv is written into the environment of every derivation. There's nothing else we can use that's guaranteed to be in every derivation that qtbase-setup-hook.sh is propagated into.

We should stop using propagatedBuildInputs.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ghost]

error: building of '/nix/store/73fp0qc16cfbn2ddhfxg9b564zix7242-llvm-16.0.6.drv!dev' from .drv file timed out after 3600 seconds

[ghost]

Rebased, maybe this time LLVM won't time out.

[Artturin]

what about the build tools?

[Artturin]

This overrides env, has to be moved to the env block

qtbase-aarch64-unknown-linux-gnu> qxcbcursor.cpp: In constructor 'QXcbCursor::QXcbCursor(QXcbConnection*, QXcbScreen*)':
qtbase-aarch64-unknown-linux-gnu> qxcbcursor.cpp:320:43: error: 'NIXPKGS_LIBXCURSOR' was not declared in this scope
qtbase-aarch64-unknown-linux-gnu>   320 |         QLibrary xcursorLib(QLatin1String(NIXPKGS_LIBXCURSOR), 1);
qtbase-aarch64-unknown-linux-gnu>       |                                           ^~~~~~~~~~~~~~~~~~