CONTRIBUTING: offer clearer guidelines about blocker vs. non-blocker issues#264651
Merged
fricklerhandwerk merged 2 commits intoNixOS:masterfrom Sep 16, 2024
Merged
CONTRIBUTING: offer clearer guidelines about blocker vs. non-blocker issues#264651fricklerhandwerk merged 2 commits intoNixOS:masterfrom
fricklerhandwerk merged 2 commits intoNixOS:masterfrom
Conversation
…issues in a PR Brought by https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$IuFJ-rB798l9jYfcWm9RyYfD5EDb420xc0kwa-FgZZo?via=nixos.org&via=matrix.org&via=nixos.dev discussion. We sometimes have reviews that are blocked because of miscommunication between author and reviewer, we make this clear so that reviewers and authors can refer to a block of "authoritative" text to unblock their own situations.
infinisil
previously requested changes
Oct 31, 2023
Member
infinisil
left a comment
infinisil
left a comment
There was a problem hiding this comment.
This section is quite large already, would be nice to have this new part (or all of its parts really) in sub sections. This way they can also be linked to.
Member
|
don't want to increase the scope of this PR, but how about something like https://conventionalcomments.org/ ? so that suggestions during review are very obviously different from requests |
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
I'm okay with mentioning as an example. |
fricklerhandwerk
dismissed
infinisil’s stale review
I think that's okay for now
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Brought by https://matrix.to/#/!kjdutkOsheZdjqYmqp:nixos.org/$IuFJ-rB798l9jYfcWm9RyYfD5EDb420xc0kwa-FgZZo?via=nixos.org&via=matrix.org&via=nixos.dev discussion.
We sometimes have reviews that are blocked because of miscommunication between author and reviewer, we make this clear so that reviewers and authors can refer to a block of "authoritative" text to unblock their own situations.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)