Skip to content

cloudflared: use go 1.20, 1.21 is too new#263841

Merged
wegank merged 1 commit intoNixOS:masterfrom
misuzu:cloudflared-fix
Oct 27, 2023
Merged

cloudflared: use go 1.20, 1.21 is too new#263841
wegank merged 1 commit intoNixOS:masterfrom
misuzu:cloudflared-fix

Conversation

@misuzu
Copy link
Contributor

@misuzu misuzu commented Oct 27, 2023

Description of changes

Fix build failure: https://hydra.nixos.org/build/238910412

unpacking sources
unpacking source archive /nix/store/3agjbs5qkgglgd7hf13xk8kkv4d0sx67-source
source root is source
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
Building subPackage ./carrier
Building subPackage ./cfapi
Building subPackage ./cfio
Building subPackage ./cmd/cloudflared
# github.com/quic-go/quic-go/internal/qtls
vendor/github.com/quic-go/quic-go/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built on Go 1.21 yet. For more details, please see https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) as int value in variable declaration

Upstream issue: cloudflare/cloudflared#1054

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@kirillrdy kirillrdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 263841 run on aarch64-linux 1

1 package built:
  • cloudflared

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 27, 2023
@wegank wegank merged commit 77fde66 into NixOS:master Oct 27, 2023
@misuzu misuzu deleted the cloudflared-fix branch October 28, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants