Skip to content

k3s: build with go_1_20#263780

Merged
wegank merged 1 commit intoNixOS:masterfrom
euank:k3s-go-1-20
Oct 30, 2023
Merged

k3s: build with go_1_20#263780
wegank merged 1 commit intoNixOS:masterfrom
euank:k3s-go-1-20

Conversation

@euank
Copy link
Member

@euank euank commented Oct 27, 2023

Description of changes

k3s upstream does not support go 1.21, so we're stuck on 1.20 for now.
See the linked issue below for more info on that!

Fixes #263580

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
    • NixOS test(s) (look inside nixos/tests)
      $ nix build '.#k3s.passthru.tests.single-node' 
      $ nix build '.#k3s_1_26.passthru.tests.single-node' 
      $ nix build '.#k3s_1_25.passthru.tests.single-node' 
      
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 27, 2023
k3s upstream does not support go 1.21, so we're stuck on 1.20 for now.

Fixes NixOS#263580
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 30, 2023
@wegank wegank merged commit 18ff78f into NixOS:master Oct 30, 2023
@superherointj superherointj added the 6.topic: k3s Kubernates distribution (https://k3s.io/) label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: k3s Kubernates distribution (https://k3s.io/) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

k3s: service fails to start, wrong go version is probably used for build

5 participants