Skip to content

lanzaboote-tool: init at 0.3.0#263712

Merged
nikstur merged 1 commit intoNixOS:masterfrom
RaitoBezarius:lanzaboote-tool
Oct 28, 2023
Merged

lanzaboote-tool: init at 0.3.0#263712
nikstur merged 1 commit intoNixOS:masterfrom
RaitoBezarius:lanzaboote-tool

Conversation

@RaitoBezarius
Copy link
Member

Description of changes

Split of #231951 for ease of review and getting this done, as requested by reviewers.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 27, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2023
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 28, 2023
@ofborg ofborg bot requested a review from nikstur October 28, 2023 14:33
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 28, 2023
@nikstur
Copy link
Contributor

nikstur commented Oct 28, 2023

The tests fail on aarch64-linux. Should we just mark it as a bad platform for now to get this merged?

@RaitoBezarius
Copy link
Member Author

The tests fail on aarch64-linux. Should we just mark it as a bad platform for now to get this merged?

That makes sense, yes.

@RaitoBezarius
Copy link
Member Author

The tests fail on aarch64-linux. Should we just mark it as a bad platform for now to get this merged?

I adopted rather an allow-list than a block-list because every other architecture won't work with lanzaboote for now.
In the future, we should adopt the badPlatforms = [ lib.systems.inspect.patterns.hasEfi ]; mechanism, in my opinon.

So we filter out any platform that is not known to possess UEFI for that specific variant of the lanzatool which will anyway be UEFI-only.

@nikstur nikstur merged commit 14e0dcb into NixOS:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants