Skip to content

libdicom: init at 1.0.5#263214

Merged
pbsds merged 1 commit intoNixOS:masterfrom
lromor:pkg-libdicom
Dec 14, 2023
Merged

libdicom: init at 1.0.5#263214
pbsds merged 1 commit intoNixOS:masterfrom
lromor:pkg-libdicom

Conversation

@lromor
Copy link
Contributor

@lromor lromor commented Oct 24, 2023 •
edited
Loading

Description of changes

Added latest version of a C library to decode DICOM files.
https://github.com/ImagingDataCommons/libdicom

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@lromor
Copy link
Contributor Author

lromor commented Oct 24, 2023

Result of nixpkgs-review pr 263214 run on x86_64-linux 1

1 package built:
  • libdicom

hzeller
hzeller reviewed Oct 24, 2023
View reviewed changes
@hzeller
Copy link
Contributor

hzeller commented Oct 24, 2023

Check https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md
The commit message should be something like

libdcom: init at 1.0.5

(also the headline of this PR)

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 24, 2023
@lromor lromor changed the title Development library: libdicom libdicom: init at 1.0.5 Oct 25, 2023
@lromor lromor requested a review from hzeller October 25, 2023 19:11
h7x4
h7x4 reviewed Oct 25, 2023
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 25, 2023
@lromor lromor requested a review from h7x4 October 25, 2023 20:20
hzeller
hzeller reviewed Oct 25, 2023
View reviewed changes
@lromor lromor requested a review from hzeller October 25, 2023 20:47
hzeller
hzeller reviewed Oct 26, 2023
View reviewed changes
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2023
@lromor
Copy link
Contributor Author

lromor commented Nov 10, 2023

@SuperSandro2000, you were the merger for openslide. This package is a dependency to openslide 4.0.0. Do you maybe have some space/time for this?

pbsds
pbsds reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 263214 run on x86_64-linux 1

1 package built:
  • libdicom

SuperSandro2000
SuperSandro2000 reviewed Dec 2, 2023
View reviewed changes
pbsds
pbsds reviewed Dec 12, 2023
View reviewed changes
@lromor lromor requested a review from pbsds December 13, 2023 09:44
pbsds
pbsds approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 263214 run on x86_64-linux 1

1 package built:
  • libdicom

LGTM!

@pbsds pbsds merged commit f3109e1 into NixOS:master Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbsds pbsds pbsds approved these changes

@h7x4 h7x4 Awaiting requested review from h7x4

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

+1 more reviewer

@hzeller hzeller hzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lromor @hzeller @pbsds @SuperSandro2000 @h7x4 @delroth