Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagemagick: 7.1.1-19 -> 7.1.1-21 #263198

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

dotlambda
Copy link
Member

Description of changes

Diff: ImageMagick/ImageMagick@7.1.1-19...7.1.1-21

Changelog: https://github.com/ImageMagick/Website/blob/main/ChangeLog.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp stigtsp merged commit 3be4a51 into NixOS:master Oct 25, 2023
@dotlambda dotlambda deleted the imagemagick-7.1.1-21 branch October 25, 2023 13:46
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@stigtsp
Copy link
Member

stigtsp commented Oct 30, 2023

There seems to be an upstream issue with linux-i686:

Maybe these commits will fix the problem:

See https://hydra.nixos.org/build/239665773/nixlog/1/tail

@misuzu
Copy link
Contributor

misuzu commented Nov 2, 2023

Same issue on armv7l-linux when building noto-fonts-emoji: https://hydra.armv7l.xyz/build/20428/nixlog/74

<.................................>
convert -size 136x128 canvas:none -compose copy -gravity center "png/128/emoji_u0023.png" -composite "PNG32:build/emoji/emoji_u0023.png"
convert -size 136x128 canvas:none -compose copy -gravity center "png/128/emoji_u0023_20e3.png" -composite "PNG32:build/emoji/emoji_u0023_20e3.png"
convert -size 136x128 canvas:none -compose copy -gravity center "png/128/emoji_u002a.png" -composite "PNG32:build/emoji/emoji_u002a.png"
convert: time limit exceeded `none' @ fatal/cache.c/GetImagePixelCache/1702.
convert: time limit exceeded `none' @ fatal/cache.c/GetImagePixelCache/1702.
convert: time limit exceeded `none' @ fatal/cache.c/GetImagePixelCache/1702.
make: *** [Makefile:164: build/emoji/emoji_u0023.png] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:164: build/emoji/emoji_u0023_20e3.png] Error 1
make: *** [Makefile:164: build/emoji/emoji_u002a.png] Error 1

@vcunat
Copy link
Member

vcunat commented Nov 2, 2023

Sure, the description seemed as universal 32-bit issue.

@Artturin Artturin mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants