Documentation for the builders (renamed: build helpers)#262648
Documentation for the builders (renamed: build helpers)#262648fricklerhandwerk merged 6 commits intoNixOS:masterfrom
Conversation
fricklerhandwerk
left a comment
There was a problem hiding this comment.
The new documentation is great and the names are terrible. Let the bikeshedfest begin.
doc/builders/builders.chapter.md
Outdated
There was a problem hiding this comment.
This should use an :::{example} block, but I wouldn't... block on that.
There was a problem hiding this comment.
Thank you for telling me that!
BTW, this part of documentation seems to be a duplication of the function reference of lib.extendMkDerivation. I originally write it here just because lib.customization was not included in the function reference then.
I think we should either:
- Link from here to the function reference, or
- Link form the function reference to here.
The first one sounds more sensible to me. It's a pity that we don't have a way to link against the documentation of each function.
There was a problem hiding this comment.
This should use an
:::{example}block, but I wouldn't... block on that.
Addressed.
The example block rendering seems a bit buggy. It randomly affects the style of the next few paragraphs (e.g. showing underline when moving the point er across the paragraphs).
There was a problem hiding this comment.
It's a pity that we don't have a way to link against the documentation of each function.
Update:
We do have a way to link against it. The anchor would be finction-library-lib.customisation.extendMkDerivation. I really hope these automatic generation of anchors could be mentioned somewhere in the documentation.
fricklerhandwerk
left a comment
There was a problem hiding this comment.
@ShamrockLee if you don't have time I could take over the fixups. If there is no further feedback in the next 1-2 weeks we should merge this.
072a09f to
204a135
Compare
|
A big wind just blew:
|
204a135 to
6a0e6ee
Compare
|
Rebase to resolve conflicts with master changes. |
fricklerhandwerk
left a comment
There was a problem hiding this comment.
This has seen quite a bit of work now, and it's a very strong improvement over the previous state of affairs.
b6be6d2 to
178495f
Compare
|
Two examples added to the "Build Helper" introduction chapter. |
f46650c to
2fc318d
Compare
|
It is only the last commit that depends on #234651. It's possible to split that commit away if we hope to merge this earlier. (Nixpkgs release 23.11 seems on the way.) |
|
Yes, let's split out that last one and merge soon. |
2fc318d to
a4ebc57
Compare
Just dropped it from this feature branch. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-10-30-documentation-team-meeting-notes-90/34936/1 |
a4ebc57 to
c57ca49
Compare
|
Rebase to resolve merge conflicts. |
c57ca49 to
f2ecbb6
Compare
|
@infinisil @roberth @RaitoBezarius this needs another approval. I'd like to merge that as is, it's a very strong improvement. |
infinisil
left a comment
There was a problem hiding this comment.
Needs another rebase, but otherwise looking good!
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
… arguments in stdenv Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
f2ecbb6 to
9d6da5b
Compare
|
The file hierarchy inside the |
Description of changes
In Nixpkgs, we have several functions that helps defining a derivation. Such function is currently called "builders", and are document in the Builders part in the Nixpkgs manual.
This PR aims to
finalAttrs: { }) to distinguish it from the recursive attribute (rec { }).Document the new approach to define a builder that supports function-based attribute recursion and add such support to existing builder implementations through(Split out of this PR)lib.extendMkDerivationandlib.extendMkDerivationModifiedintroduced in lib.extendMkDerivation: init #234651.This PR also
darwin.linux-builderfrom chapter Special build helper to chapter Packages, and emphasize that it is about remote builder bootstrap instead of build helpers.doc/build-helpers/packages/->doc/packages/to make it parallel todoc/hooks/and prepare for future migration. (The Packages chapter is mostly not about build helpers.)Closes #235858
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)