Skip to content

python311Packages.connexion: 2.14.2 -> 3.0.1#262544

Closed
mweinelt wants to merge 2 commits intoNixOS:masterfrom
mweinelt:connexion-3.0.0a7
Closed

python311Packages.connexion: 2.14.2 -> 3.0.1#262544
mweinelt wants to merge 2 commits intoNixOS:masterfrom
mweinelt:connexion-3.0.0a7

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Oct 21, 2023

Description of changes

Updated to provide compatibility with flask 2.3.x.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@mweinelt
python311Packages.py-swagger-ui: init at 1.1.0
1cfa4d3 
Packaged as a dependency for connexion.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 21, 2023
@mweinelt
Copy link
Member Author

mweinelt commented Oct 21, 2023

Not a valid fix for airflow. Requires a flask downgrade unfortunately.

Result of nixpkgs-review pr 262544 run on x86_64-linux 1

2 packages failed to build:
  • apache-airflow
  • apache-airflow.dist
8 packages built:
  • python310Packages.connexion
  • python310Packages.connexion.dist
  • python310Packages.py-swagger-ui
  • python310Packages.py-swagger-ui.dist
  • python311Packages.connexion
  • python311Packages.connexion.dist
  • python311Packages.py-swagger-ui
  • python311Packages.py-swagger-ui.dist

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 21, 2023
@ofborg ofborg bot requested a review from elohmeier October 21, 2023 16:14
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 21, 2023
@vcunat vcunat changed the base branch from staging-next to master October 28, 2023 06:17
jonringer
jonringer approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged into staging-next fine.

@mweinelt
Copy link
Member Author

mweinelt commented Nov 5, 2023 •
edited
Loading

I think this can be merged into staging-next fine.

Master should work just fine, flask 2.3.3 is already there.

Edit: swagger tests are failing now.

@mweinelt
Copy link
Member Author

mweinelt commented Nov 6, 2023

apache-airflow> ModuleNotFoundError: No module named 'connexion.decorators.validation'

What is needed is a flask pin on airflow.

Result of nixpkgs-review pr 262544 run on x86_64-linux 1

2 packages failed to build:
  • apache-airflow
  • apache-airflow.dist
8 packages built:
  • python310Packages.connexion
  • python310Packages.connexion.dist
  • python310Packages.py-swagger-ui
  • python310Packages.py-swagger-ui.dist
  • python311Packages.connexion
  • python311Packages.connexion.dist
  • python311Packages.py-swagger-ui
  • python311Packages.py-swagger-ui.dist

@natsukium natsukium changed the title python311Packages.connexion: 2.14.2 -> 3.0.0a7 python311Packages.connexion: 2.14.2 -> 3.0.0 Nov 12, 2023
@mweinelt mweinelt changed the title python311Packages.connexion: 2.14.2 -> 3.0.0 python311Packages.connexion: 2.14.2 -> 3.0.1 Nov 12, 2023
@mweinelt
Copy link
Member Author

mweinelt commented Nov 12, 2023

Result of nixpkgs-review pr 262544 run on x86_64-linux 1

2 packages failed to build:
  • apache-airflow
  • apache-airflow.dist
8 packages built:
  • python310Packages.connexion
  • python310Packages.connexion.dist
  • python310Packages.py-swagger-ui
  • python310Packages.py-swagger-ui.dist
  • python311Packages.connexion
  • python311Packages.connexion.dist
  • python311Packages.py-swagger-ui
  • python311Packages.py-swagger-ui.dist

@boltzmannrain
Copy link
Contributor

boltzmannrain commented Nov 14, 2023

Tried this and I think apache-airflow is hitting apache/airflow#35234 which doesn't yet have a fix

  File "/nix/store/x6dp50lbvz2b1av3rrvam5iyc5nlmwg5-python3.11-apache-airflow-2.7.1/lib/python3.11/site-packages/airflow/migrations/versions/0074_2_0_0_resource_based_permissions.py", line 30, in <module>
    from airflow.www.app import cached_app
  File "/nix/store/x6dp50lbvz2b1av3rrvam5iyc5nlmwg5-python3.11-apache-airflow-2.7.1/lib/python3.11/site-packages/airflow/www/app.py", line 50, in <module>
    from airflow.www.extensions.init_views import (
  File "/nix/store/x6dp50lbvz2b1av3rrvam5iyc5nlmwg5-python3.11-apache-airflow-2.7.1/lib/python3.11/site-packages/airflow/www/extensions/init_views.py", line 25, in <module>
    from connexion.decorators.validation import RequestBodyValidator
ModuleNotFoundError: No module named 'connexion.decorators.validation'

@mweinelt
Copy link
Member Author

mweinelt commented Nov 14, 2023

Yeah, apache-airflow is broken right now, because it also doesn't like flask 2.3.

@mweinelt
Copy link
Member Author

mweinelt commented Dec 26, 2023

Superseded by #271586.

@mweinelt mweinelt closed this Dec 26, 2023
@mweinelt mweinelt deleted the connexion-3.0.0a7 branch December 26, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elohmeier elohmeier Awaiting requested review from elohmeier

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @boltzmannrain @jonringer