nixos/release.nix: remove unused withs #262497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
roberth
reviewed
Oct 21, 2023
| { module, maintainers ? ["viric"], system }: | ||
|
|
||
| with import ./.. { inherit system; }; | ||
|
|
Member
There was a problem hiding this comment.
Still needed for meta.description
$ nix-instantiate --eval nixos/release.nix -A containerTarball.x86_64-linux.meta.description
error: undefined variable 'stdenv'
wegank
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was originally part of #258564, but I dropped it from there when I changed approach. It still has merit on its own.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)