Skip to content

poetry2nix: 1.42.1 -> 2023.10.16.33693#262429

Closed
l0b0 wants to merge 1 commit intoNixOS:masterfrom
l0b0:poetry2nix-2023.10.16.33693
Closed

poetry2nix: 1.42.1 -> 2023.10.16.33693#262429
l0b0 wants to merge 1 commit intoNixOS:masterfrom
l0b0:poetry2nix-2023.10.16.33693

Conversation

@l0b0
Copy link
Contributor

@l0b0 l0b0 commented Oct 21, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@l0b0 l0b0 requested a review from adisbladis as a code owner October 21, 2023 01:32
@roberth
Copy link
Member

roberth commented Oct 21, 2023

  • ofborg produces an error involving python 2.7 somehow
  • this doesn't work for nixops_unstable

I've tried to fix nixops' eval error using this, because its current eval error comes from poetry2nix's own files.

The error is a divergent infinite recursion, so unfortunately, I don't have an evaluation trace for it, but I have observed the loop through verbose logging.

Shortly before the loop:

instantiated 'python3.10-bootstrap-flit-core-3.9.0' -> '/nix/store/ywzpzlkmp0rbmz21ziwwjbwgynqfakg2-python3.10-bootstrap-flit-core-3.9.0.drv'
evaluating file '/home/user/h/nixpkgs/pkgs/development/python-modules/bootstrap/installer/default.nix'
evaluating file '/home/user/h/nixpkgs/pkgs/development/python-modules/installer/default.nix'
instantiated 'source' -> '/nix/store/kzp5mfwd5p759mkgwia1dgcgsddbr9my-source.drv'
instantiated 'python3.10-bootstrap-installer-0.7.0' -> '/nix/store/garcn982ah65akbry7wzxpasb13amrqk-python3.10-bootstrap-installer-0.7.0.drv'
evaluating file '/home/user/h/nixpkgs/pkgs/development/python-modules/pyproject-hooks/default.nix'
evaluating file '/home/user/h/nixpkgs/pkgs/build-support/fetchpypi/default.nix'

The loop itself consists of this repeated set of lines:

log starting with pyproject_hooks, ending with bootstrap-installer [click]
instantiated 'pyproject_hooks-1.0.0.tar.gz' -> '/nix/store/7lg3d41h9gslk4k47ydcgvaizki69axy-pyproject_hooks-1.0.0.tar.gz.drv'
instantiated 'python3.10-bootstrap-pyproject-hooks-1.0.0' -> '/nix/store/0j4ksf6yhmasl45wig4ifvys2y218pcy-python3.10-bootstrap-pyproject-hooks-1.0.0.drv'
evaluating file '/home/user/h/nixpkgs/pkgs/development/python-modules/packaging/default.nix'
instantiated 'packaging-23.1.tar.gz' -> '/nix/store/cpk8f936s3iszh05icgd1c8bz2d7rhrl-packaging-23.1.tar.gz.drv'
instantiated 'python3.10-bootstrap-packaging-23.1' -> '/nix/store/7y1i7f7zmaqmjhd7br9sqjzc3w7v8g6p-python3.10-bootstrap-packaging-23.1.drv'
evaluating file '/home/user/h/nixpkgs/pkgs/development/python-modules/tomli/default.nix'
instantiated 'source' -> '/nix/store/xh4w027x5ahy68p3idzxlph5a38rd4rd-source.drv'
instantiated 'python3.10-bootstrap-tomli-2.0.1' -> '/nix/store/gqizncs4f2zq5fi0z2kirp7la10sdjdv-python3.10-bootstrap-tomli-2.0.1.drv'
instantiated 'source' -> '/nix/store/w6fl1dqjvc7q74ris8m6kprmajnqsd4y-source.drv'
instantiated 'python3.10-bootstrap-build-0.10.0' -> '/nix/store/3lhqpkdmij6yml2593smnxb4irprs75y-python3.10-bootstrap-build-0.10.0.drv'
copied source '/home/user/h/nixpkgs/pkgs/development/interpreters/python/hooks/pypa-build-hook.sh' -> '/nix/store/hbynvv2770avphlyi2f6bdqvqs8qifhx-pypa-build-hook.sh'
instantiated 'pypa-build-hook.sh' -> '/nix/store/46i3vim2nmbblf82v471qabih7hzg3p5-pypa-build-hook.sh.drv'
copied source '/home/user/h/nixpkgs/pkgs/development/interpreters/python/hooks/pypa-install-hook.sh' -> '/nix/store/ib3rz26ch1p4fjxiwkwvzrd4r7yw57l6-pypa-install-hook.sh'
instantiated 'python-setup-hook.sh' -> '/nix/store/1ggi1d0idq4ikpxqv886sd7f9467psfc-python-setup-hook.sh.drv'
instantiated 'Python-3.10.12.tar.xz' -> '/nix/store/a5hx93i2r3x2g00kd5ywb2phj91hfq59-Python-3.10.12.tar.xz.drv'
instantiated 'python3-3.10.12' -> '/nix/store/fbyjcpdqv92z8fc85plz3m6j4f0m2jv2-python3-3.10.12.drv'
instantiated 'python-setup-hook.sh' -> '/nix/store/1ggi1d0idq4ikpxqv886sd7f9467psfc-python-setup-hook.sh.drv'
instantiated 'Python-3.10.12.tar.xz' -> '/nix/store/a5hx93i2r3x2g00kd5ywb2phj91hfq59-Python-3.10.12.tar.xz.drv'
instantiated 'python3-3.10.12' -> '/nix/store/fbyjcpdqv92z8fc85plz3m6j4f0m2jv2-python3-3.10.12.drv'
instantiated 'wrap-python-hook' -> '/nix/store/ipxz7lkjp6jjr6xkcvz33jal354154gh-wrap-python-hook.drv'
instantiated 'python-remove-tests-dir-hook' -> '/nix/store/13cyxa5v1syj13xmzsccs0s9bq98gxcg-python-remove-tests-dir-hook.drv'
instantiated 'python-remove-bin-bytecode-hook' -> '/nix/store/9ch8hyg0zjccvav10pmrs92a7lkswmrl-python-remove-bin-bytecode-hook.drv'
instantiated 'source' -> '/nix/store/6xf538aynk7v7g573rhdd973vskip143-source.drv'
instantiated 'python3.10-bootstrap-flit-core-3.9.0' -> '/nix/store/ywzpzlkmp0rbmz21ziwwjbwgynqfakg2-python3.10-bootstrap-flit-core-3.9.0.drv'
instantiated 'source' -> '/nix/store/kzp5mfwd5p759mkgwia1dgcgsddbr9my-source.drv'
instantiated 'python3.10-bootstrap-installer-0.7.0' -> '/nix/store/garcn982ah65akbry7wzxpasb13amrqk-python3.10-bootstrap-installer-0.7.0.drv'
tiny patch to pkgs/applications/networking/cluster/nixops/update
diff --git a/pkgs/applications/networking/cluster/nixops/update b/pkgs/applications/networking/cluster/nixops/update
index 1d1fd93fdbea..3f2b7f48a5ae 100755
--- a/pkgs/applications/networking/cluster/nixops/update
+++ b/pkgs/applications/networking/cluster/nixops/update
@@ -8,4 +8,4 @@ poetry lock
 
 # builtins.fetchGit is disabled in restricted eval
 # Pin fixed-output derivations from lock file
-poetry2nix lock
+poetry2nix-cli lock

It appears that the following needs to be done

  • Avoid evaluating poetry2nix on python27? I'd be surprised if we need poetry2nix with 2.7
  • Fix the bootstrapping; see error log details

@roberth
Copy link
Member

roberth commented Oct 21, 2023

Maybe we need something like this? It seems to relate to the log.

@ajs124
Copy link
Member

ajs124 commented Nov 13, 2023

obsolete after #263308

@ajs124 ajs124 closed this Nov 13, 2023
@l0b0 l0b0 deleted the poetry2nix-2023.10.16.33693 branch August 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants