-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lunarvim: init at 1.3.0 #261103
lunarvim: init at 1.3.0 #261103
Conversation
dbde290
to
9dca2b8
Compare
9dca2b8
to
33ce467
Compare
33ce467
to
9454692
Compare
9454692
to
4c1dbc2
Compare
Works for me 👍 I am, however, still pulling in the patch mentioned here, because lvim 1.3.0 doesn't work with nixpkgs's version of nerdfonts. |
4c1dbc2
to
99dadc5
Compare
This is fair—having a broken out-of-the-box interface is an annoying experience, and there is no indication as to when the next release will be pushed. |
99dadc5
to
749c639
Compare
749c639
to
5773474
Compare
@ProminentRetail Does it really need cargo to build? I ask because I'm managing rust/cargo separately with rust-overlay |
I don't think it strictly does; I've included |
5773474
to
df91eee
Compare
Ok, I installed using your package, and it mostly works, except it cannot create or access ~/.config/lvim/config.lua on the first run. Somehow though, this error went away on the next run. The nerdfont iconset doesn't seem to be included as a dependency, and manually adding nerdfonts to the devshell doesn't seem to fix it |
Let me go on a siderant: I am not a fan of those vim distribs because IMO they sidestep the issue, a (GUI) tool that can help generate a proper neovim config aka sthg like https://github.com/teto/vim-config . Nevertheless they are a good way for newbies to show what is possible.
These distribs make even less sense on nixpkgs IMO because one of their major business is to install software but nix makes it even more reliable. I expect people to run lvim because they want something convenient they dont have to fiddle too much with. In that context, I think it makes sense to lean on providing more software rather than less. I would provide cargo for instance (not in the global PATH, just visible from neovim by wrapping neovim with cargo in its PATH like home-manager does in |
I use LunarVim because I don't want to have to think too hard about all the boilerplate, and it has a decent-sized community. The idea that I can just add
I hear you, but for something as dynamically personalised as an editor, I appreciate the happy medium that a LunarVim configuration provides in declarativeness, lack of extra fiddling, and rapid iteration. Of course, my opinion is very liable to change. :P
I definitely agree that the whole point is to provide a frictionless, friendly out-of-the-box experience; I've been pulled back and forth on this, but I do think including Cargo and npm by default aligns with this philosophy. Is there any problem with the way I'm currently including runtime dependencies by calling |
711886e
to
461dd3f
Compare
461dd3f
to
ace8d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me. I am not the best to check if it doesn't break lunarvim but we can iterate on it anyway.
everything worked perfectly, even when I copied my custom config into the lunarvim directory, truly amazing, great job 👏 not sure if is needed, but I had to add |
Instead of adding gnumake, would it make sense to include the nix plugin telescope-fzf-native.nvim in the neovim wrapper instead ? depend on if lunarvim wants to control the version of the plugin. |
afaik lunarvim doesn't have any type of version lock system for plugins, u are free to manage plugins version using Lazy, it has the risk of braking some lunarvim features depending on the update, but I believe that is expected |
Great to hear!
Is |
I think it makes sense to relinquish control of plugin management to LunarVim. |
For me it wasn't pulled, I got the error at the first LunarVim start when Lazy.vim begins downloading the plugins, after adding it to my system pkgs it worked as expected. |
Hm, this is really weird. I don't have |
I've just realised that we need to include |
f1c6721
to
9f884cc
Compare
9f884cc
to
1d6f7bf
Compare
@ProminentRetail would it be possible for you to package AstroNvim as well? Thank you very much for this. |
Jeah Astrovim would be very nice. Can we help here in some way? |
@ProminentRetail the next release of LunarVim is taking a while, I was thinking about overriding to use |
|
Description of changes
Follow-up to #257063. Closes #178488 and LunarVim/LunarVim#1507.
Differences to the original PR:
globalConfig
to replicate neovimRcContent) by inserting a line here prior to the post-load hook for the configuration.nvimAlias
,viAlias
andvimAlias
by mimicking neovim.install_bin.sh
, I generate the launch script manually. This turns out to be simpler since I need to replace thenvim
call to be compatible withnvimAlias
anyway.cargo
,make
andnodejs
as per LunarVim's prerequisites.curl
,gzip
,gnutar
andunzip
as per mason.nvim's requirements.lua-language-server
out of the box as soon as a Lua file is opened; this will happen for virtually every user since the configuration is in Lua. However, the mason.nvim installation is not functional, as the Nixpkgs derivation does some extra stuff to make things work. I'm solving this by addinglua-language-server
manually and giving our version priority by causing the mason.nvim binary path to be appended rather than prepended. This will also allow users to easily override any other language server binaries causing problems.stdenv.cc
to get nvim-treesitter to work.Considerations:
fd
andripgrep
as required dependencies, but we're including them by default anyway (also see Dependency for Telescope: fd LunarVim/lunarvim.org#333). This makes sense to me since LunarVim's philosophy is to have "sane defaults", but I have no real conviction here.lazygit
by default as per LunarVim's optional feature prerequisites?Thanks! 😸
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)