Skip to content

top-level/aliases: remove warning from rocm-opencl-{icd,runtime}#260910

Merged
lovesegfault merged 1 commit intoNixOS:masterfrom
Madouura:pr/rocm-warning
Oct 13, 2023
Merged

top-level/aliases: remove warning from rocm-opencl-{icd,runtime}#260910
lovesegfault merged 1 commit intoNixOS:masterfrom
Madouura:pr/rocm-warning

Conversation

@Madouura
Copy link
Contributor

Description of changes

#258328 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

After 23.11 is released, we want to convert this to a throw like the others
@Madouura
Copy link
Contributor Author

Result of nixpkgs-review pr 260910 run on x86_64-linux 1

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 13, 2023
@lovesegfault lovesegfault merged commit 1f588ca into NixOS:master Oct 13, 2023
@lovesegfault
Copy link
Member

You rock :)

@Madouura Madouura deleted the pr/rocm-warning branch October 13, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants