Skip to content

Comments

blobwars: fix build against glibc-2.38#260238

Merged
Ma27 merged 1 commit intoNixOS:staging-nextfrom
trofi:blobwars-fix-for-glibc-2.38
Oct 13, 2023
Merged

blobwars: fix build against glibc-2.38#260238
Ma27 merged 1 commit intoNixOS:staging-nextfrom
trofi:blobwars-fix-for-glibc-2.38

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 10, 2023

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Oct 10, 2023
12 tasks
@ofborg ofborg bot requested a review from iblech October 10, 2023 16:29
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 10, 2023
@Ma27 Ma27 merged commit 59f594f into NixOS:staging-next Oct 13, 2023
@trofi trofi deleted the blobwars-fix-for-glibc-2.38 branch October 13, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants