minetest-mapserver: init at 4.7.0#259915
Merged
nlewo merged 2 commits intoNixOS:masterfrom Oct 11, 2023
Merged
Conversation
cafkafk
reviewed
Oct 9, 2023
Member
cafkafk
left a comment
There was a problem hiding this comment.
code lgtm, sending result of nixpkgs-review when done.
Member
|
Result of 1 package built:
|
cafkafk
approved these changes
Oct 9, 2023
Member
cafkafk
left a comment
There was a problem hiding this comment.
seems to build fine, didn't test with a world.mt
Contributor
Author
Works for me. The binary must be called from the directory where |
nlewo
requested changes
Oct 11, 2023
Member
nlewo
left a comment
There was a problem hiding this comment.
Could you squash your lastest commit with the commit introducing the software (in order to only have 2 commits)?
61d2ccf to
6b989a0
Compare
Contributor
Author
Of course! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This package provides a web-based real-time mapserver for minetest voxel game servers: https://github.com/minetest-mapserver/mapserver/blob/master/readme.md
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)