Skip to content

Comments

minetest-mapserver: init at 4.7.0#259915

Merged
nlewo merged 2 commits intoNixOS:masterfrom
zeuner:minetest-mapserver
Oct 11, 2023
Merged

minetest-mapserver: init at 4.7.0#259915
nlewo merged 2 commits intoNixOS:masterfrom
zeuner:minetest-mapserver

Conversation

@zeuner
Copy link
Contributor

@zeuner zeuner commented Oct 9, 2023

Description of changes

This package provides a web-based real-time mapserver for minetest voxel game servers: https://github.com/minetest-mapserver/mapserver/blob/master/readme.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2023
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, sending result of nixpkgs-review when done.

@cafkafk
Copy link
Member

cafkafk commented Oct 9, 2023

Result of nixpkgs-review pr 259915 run on x86_64-linux 1

1 package built:
  • minetest-mapserver

Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to build fine, didn't test with a world.mt

@zeuner
Copy link
Contributor Author

zeuner commented Oct 9, 2023

seems to build fine, didn't test with a world.mt

Works for me. The binary must be called from the directory where world.mt resides.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2023
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, lgtm.

@zeuner zeuner requested a review from nlewo October 10, 2023 09:00
@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2023
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash your lastest commit with the commit introducing the software (in order to only have 2 commits)?

@zeuner zeuner force-pushed the minetest-mapserver branch from 61d2ccf to 6b989a0 Compare October 11, 2023 10:16
@zeuner
Copy link
Contributor Author

zeuner commented Oct 11, 2023

Could you squash your lastest commit with the commit introducing the software (in order to only have 2 commits)?

Of course!

@zeuner zeuner requested a review from nlewo October 11, 2023 10:17
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@nlewo nlewo merged commit dfe563c into NixOS:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants