Skip to content

graalvm-oracle: init at 21#259639

Closed
ericdallo wants to merge 1 commit intoNixOS:masterfrom
ericdallo:oracle-graalvm
Closed

graalvm-oracle: init at 21#259639
ericdallo wants to merge 1 commit intoNixOS:masterfrom
ericdallo:oracle-graalvm

Conversation

@ericdallo
Copy link
Member

@ericdallo ericdallo commented Oct 7, 2023 •
edited
Loading

Fixes #259631

Description of changes

This adds oracle-graalvm and make buildGraalvm more generic to be used on other places than community-edition.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ericdallo ericdallo requested a review from thiagokokada October 7, 2023 21:58
thiagokokada
thiagokokada requested changes Oct 7, 2023
View reviewed changes
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 7, 2023
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2023
@ericdallo
Copy link
Member Author

ericdallo commented Oct 15, 2023

Is there anything missing @thiagokokada?

thiagokokada
thiagokokada reviewed Oct 16, 2023
View reviewed changes
pkgs/top-level/all-packages.nix
Comment on lines +16484 to 16488
graalvmPackages =
recurseIntoAttrs (callPackage ../development/compilers/graalvm { });
graalvmCEPackages =
recurseIntoAttrs (callPackage ../development/compilers/graalvm/community-edition { });
graalvm-ce = graalvmCEPackages.graalvm-ce;
Copy link
Contributor

@thiagokokada thiagokokada Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to create this graalvmPackages, I think we need to do a clean-up.

Please move all packages to be under the graalvmPackages, and make the graalvmCEPackages an alias to graalvmPackages.

Copy link
Member Author

@ericdallo ericdallo Oct 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the others may not make sense for now as they are not available for oracle?

Copy link
Contributor

@thiagokokada thiagokokada Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

graalvmCEPackages was a mistake by itself because community edition is just a detail of the package, but since we didn't have a better reason to do so it was never fixed.

Since we are going to introduce graalvmPackages anyway, we can simply fix this mistake and deprecate graalvmCEPackages later.

@jcf jcf mentioned this pull request Nov 22, 2023
Closed
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 8, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@farnoy
Copy link
Member

farnoy commented May 22, 2024

Is there anything missing here before it can land? I do see the merge conflict, and a new version (22) has been released since this PR was opened.

@farnoy farnoy mentioned this pull request Jun 19, 2024
Merged
13 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@ghost ghost closed this Dec 19, 2024
@ghost ghost marked this as a duplicate of #321026 Jan 22, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@hlolli hlolli Awaiting requested review from hlolli

@glittershark glittershark Awaiting requested review from glittershark

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

+1 more reviewer

@babariviere babariviere babariviere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package request: Oracle Graalvm 21

5 participants

@ericdallo @farnoy @thiagokokada @babariviere @wegank