mysql service: Make initialDatabases.schema attribute optional#25950
Merged
fpletz merged 1 commit intoNixOS:masterfrom Aug 31, 2017
Merged
mysql service: Make initialDatabases.schema attribute optional#25950fpletz merged 1 commit intoNixOS:masterfrom
fpletz merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
Author
|
Related to #6963 , implementing a small part of it using the already existing initialDatabases option. |
Contributor
Author
|
From the git log of the file, as the bot seems to be inactive: @joachifm maybe you could take a look, or recommend someone else to ask? 😊 |
Contributor
|
cc @grahamc |
fpletz
added
the
8.has: module (update)
Member
|
MySQL tests are still green. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
the
services.mysql.initialDatabaseslist does not allow to create empty initial databases, e.g. for web apps like piwik or nextcloud that create their own initial schema via their web installer.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)