Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merkaartor: build with cmake #259434

Merged
merged 1 commit into from
Oct 14, 2023
Merged

merkaartor: build with cmake #259434

merged 1 commit into from
Oct 14, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Oct 6, 2023

Description of changes

https://github.com/openstreetmap/merkaartor/blob/0.19.0/Merkaartor.pro

qmake support is deprecated, please use cmake build system whenever possible. qmake support will be removed in 0.20.0 release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@sikmir
Copy link
Member

sikmir commented Oct 6, 2023

Result of nixpkgs-review pr 259434 run on x86_64-linux 1

1 package failed to build:
  • merkaartor
error: builder for '/nix/store/b4c5hs4509g37l7y9kmb1ysd1916jjrj-merkaartor-0.19.0.drv' failed with exit code 1;
       last 10 log lines:
       > -- Checking for modules 'gdal;proj;exiv2;gpsd'
       > --   No package 'gpsd' found
       > CMake Error at /nix/store/yi235g10sp8jx939zpfli0s74154ph3v-cmake-3.26.4/share/cmake-3.26/Modules/FindPkgConfig.cmake:607 (message):
       >   A required package was not found
       > Call Stack (most recent call first):
       >   /nix/store/yi235g10sp8jx939zpfli0s74154ph3v-cmake-3.26.4/share/cmake-3.26/Modules/FindPkgConfig.cmake:829 (_pkg_check_modules_internal)
       >   CMakeLists.txt:523 (pkg_check_modules)
       >
       >
       > -- Configuring incomplete, errors occurred!

@wegank wegank marked this pull request as draft October 7, 2023 15:31
@sikmir
Copy link
Member

sikmir commented Oct 12, 2023

What about adding the patch? Since no response from upstream.

@sikmir
Copy link
Member

sikmir commented Oct 12, 2023

Result of nixpkgs-review pr 259434 run on x86_64-linux 1

1 package built:
  • merkaartor

@ofborg ofborg bot requested a review from sikmir October 12, 2023 18:44
@wegank wegank marked this pull request as ready for review October 12, 2023 20:46
@wegank wegank merged commit d0f0927 into NixOS:master Oct 14, 2023
22 checks passed
@wegank wegank deleted the merkaartor-cmake branch October 14, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants