Skip to content

go_1_20: 1.20.8 -> 1.20.9#259333

Closed
mfrw wants to merge 1 commit intoNixOS:masterfrom
mfrw:mfrw/golang-1.20.9
Closed

go_1_20: 1.20.8 -> 1.20.9#259333
mfrw wants to merge 1 commit intoNixOS:masterfrom
mfrw:mfrw/golang-1.20.9

Conversation

@mfrw
Copy link
Member

@mfrw mfrw commented Oct 6, 2023

Description of changes

Changelog: https://go.dev/doc/devel/release#go1.20

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. label Oct 6, 2023
@mfrw mfrw marked this pull request as ready for review October 6, 2023 06:29
@mfrw mfrw requested review from Mic92, kalbasit and zowoq as code owners October 6, 2023 06:29
@ofborg ofborg bot requested a review from qbit October 6, 2023 07:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 6, 2023
@ajs124 ajs124 added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-23.05 labels Oct 6, 2023
@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 6, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 6, 2023
@fabianhjr
Copy link
Member

Rebuilds seem low, could this go to the main branch directly?

@mfrw
Copy link
Member Author

mfrw commented Oct 7, 2023

Rebuilds seem low, could this go to the main branch directly?

I can retarget this to master. I was not aware of how many rebuilds would happen at the time I made the PR so thought better to target staging.

Should I go ahead and retarget this ? @fabianhjr

@fabianhjr
Copy link
Member

Sure, though note that you may need to rebase your branch to the merge-base before changing the target branch in github to avoid a mass ping. (More info at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging )

@mfrw mfrw changed the base branch from staging to master October 7, 2023 04:08
@mfrw
Copy link
Member Author

mfrw commented Oct 7, 2023

Sure, though note that you may need to rebase your branch to the merge-base before changing the target branch in github to avoid a mass ping. (More info at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging )

Even though you gave such a nice pointer, I still managed to mess it up :(
Sincere apologies @fabianhjr

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 7, 2023
@mfrw mfrw force-pushed the mfrw/golang-1.20.9 branch from b5e2ab4 to 6a59a65 Compare October 7, 2023 04:22
@fabianhjr
Copy link
Member

Happens from time to time. 😅

Will diverge from the procedure merge when ofborg succeeds since notifications are low enuough and change is small enough.

@NixOS NixOS locked as too heated and limited conversation to collaborators Oct 7, 2023
@ofborg ofborg bot requested review from kalbasit and qbit October 7, 2023 04:28
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 7, 2023
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Oct 7, 2023
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 7, 2023
@fabianhjr
Copy link
Member

Oh no, I messed up to I apologize as well, lost track of where the default go version change was so far.

#254878

Could you create a new pull request targeting staging-next?

Reference

go, buildGoModule, buildGoPackage: default to 1.21

    [python-updates](https://github.com/NixOS/nixpkgs/compare/python-updates) ([#254878](https://github.com/NixOS/nixpkgs/pull/254878)) [staging](https://github.com/NixOS/nixpkgs/compare/staging) ([hllizi/nixpkgs#1](https://github.com/hllizi/nixpkgs/pull/1), [#254878](https://github.com/NixOS/nixpkgs/pull/254878)) [staging-next](https://github.com/NixOS/nixpkgs/compare/staging-next) ([#257792](https://github.com/NixOS/nixpkgs/pull/257792), [#254878](https://github.com/NixOS/nixpkgs/pull/254878))

@fabianhjr fabianhjr closed this Oct 7, 2023
@mfrw mfrw deleted the mfrw/golang-1.20.9 branch October 7, 2023 04:41
@drupol drupol removed 1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants