enable hydra jobs for some of the darwin only packages#25930
enable hydra jobs for some of the darwin only packages#25930LnL7 wants to merge 1 commit intoNixOS:masterfrom
Conversation
Due to the way packagePlatforms and the fact that it's not possible to access drv.meta of a 'broken' package all of the darwin only packages are filtered out of the job in release.nix.
|
@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @Ericson2314 and @grahamc to be potential reviewers. |
|
I suppose this is fine as temporary workaround. |
|
We could map over supported systems, and then recursively union the result. It will be slower but doubt it matters. I'd be happy to write that. |
|
I thought about that, but was afraid it would be a significant performance hit. |
|
If it's not too much trouble could you add a few more jobs:
|
|
How about this: https://github.com/NixOS/nixpkgs/compare/master...dezgeg:darwin-in-release?expand=1 ? Adds these: Sounds like some of the |
|
We should change the fallback for no meta in release-lib to include all of supported systems. Then we only need to worry about the case where the meta is explicitly darwin only. |
Most packages without meta are probably not very well maintained. I think making people put these in is probably good in pushing people to think about other platforms than their own. |
|
@matthewbauer err are we agreeing :)? I'd think the more optimistic the default is, the more obvious any failures will be so it doesn't slip through the cracks. |
Yeah I guess I don't feel that strongly either way. My big concern was just the build farm running things it doesn't need to - but either way sounds fine. |
|
@Ericson2314 @LnL7 Can this be merged now? it would definitely make things easier to track Darwin-specific jobs. #26774 |
|
I think @dezgeg's solution is a lot better. |
|
@matthiasbeyer you just have Darwin derivations, not derivations missing meta on the list, right? Then sounds good to me. |
|
Yeah if they were missing meta, I could just fix them on my own. With Darwin-only we're kind of stuck. |
|
Ah sorry, I forgot you couldn't merge this yourself. I'll gladly merge once the conflict is fixed. |
|
Closing in favour of #28174. |
Motivation for this change
Fixes #25200.
Maybe there's another/better way to fix this?
Due to the way packagePlatforms and the fact that it's not possible to
access drv.meta of a 'broken' package all of the darwin only packages
are filtered out of the job in release.nix.
Things done