Skip to content

enable hydra jobs for some of the darwin only packages#25930

Closed
LnL7 wants to merge 1 commit intoNixOS:masterfrom
LnL7:darwin-hydra-jobs
Closed

enable hydra jobs for some of the darwin only packages#25930
LnL7 wants to merge 1 commit intoNixOS:masterfrom
LnL7:darwin-hydra-jobs

Conversation

@LnL7
Copy link
Member

@LnL7 LnL7 commented May 19, 2017

Motivation for this change

Fixes #25200.

Maybe there's another/better way to fix this?

Due to the way packagePlatforms and the fact that it's not possible to
access drv.meta of a 'broken' package all of the darwin only packages
are filtered out of the job in release.nix.

Things done

Due to the way packagePlatforms and the fact that it's not possible to
access drv.meta of a 'broken' package all of the darwin only packages
are filtered out of the job in release.nix.
@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @Ericson2314 and @grahamc to be potential reviewers.

@LnL7 LnL7 changed the title enable jobs for some of the darwin only packages enable hydra jobs for some of the darwin only packages May 19, 2017
@Ericson2314
Copy link
Member

I suppose this is fine as temporary workaround.

@Ericson2314
Copy link
Member

Ericson2314 commented May 19, 2017

We could map over supported systems, and then recursively union the result. It will be slower but doubt it matters. I'd be happy to write that.

@LnL7
Copy link
Member Author

LnL7 commented May 19, 2017

I thought about that, but was afraid it would be a significant performance hit.

@matthewbauer
Copy link
Member

If it's not too much trouble could you add a few more jobs:

  • file_cmds
  • DarwinTools

@dezgeg
Copy link
Contributor

dezgeg commented May 21, 2017

How about this: https://github.com/NixOS/nixpkgs/compare/master...dezgeg:darwin-in-release?expand=1 ?

Adds these:

contacts.x86_64-darwin
darwin.CarbonHeaders.x86_64-darwin
darwin.CommonCrypto.x86_64-darwin
darwin.Csu.x86_64-darwin
darwin.DarwinTools.x86_64-darwin
darwin.IOKit.x86_64-darwin
darwin.Libc.x86_64-linux
darwin.Libc_old.x86_64-linux
darwin.Libinfo.x86_64-linux
darwin.Libm.x86_64-linux
darwin.Libnotify.x86_64-linux
darwin.Librpcsvc.x86_64-darwin
darwin.Libsystem.x86_64-darwin
darwin.Security.x86_64-linux
darwin.adv_cmds.x86_64-darwin
darwin.architecture.x86_64-darwin
darwin.basic_cmds.x86_64-darwin
darwin.bootstrap_cmds.x86_64-linux
darwin.bsdmake.x86_64-linux
darwin.copyfile.x86_64-linux
darwin.developer_cmds.x86_64-darwin
darwin.dyld.x86_64-darwin
darwin.eap8021x.x86_64-linux
darwin.file_cmds.x86_64-darwin
darwin.launchd.x86_64-linux
darwin.libauto.x86_64-linux
darwin.libclosure.x86_64-linux
darwin.libdispatch.x86_64-linux
darwin.libiconv.x86_64-linux
darwin.libobjc.x86_64-linux
darwin.libpthread.x86_64-linux
darwin.libunwind.x86_64-darwin
darwin.libutil.x86_64-darwin
darwin.locale.x86_64-darwin
darwin.mDNSResponder.x86_64-linux
darwin.maloader.x86_64-linux
darwin.network_cmds.x86_64-darwin
darwin.objc4.x86_64-linux
darwin.opencflite.x86_64-linux
darwin.osx_private_sdk.x86_64-linux
darwin.ppp.x86_64-linux
darwin.ps.x86_64-darwin
darwin.removefile.x86_64-linux
darwin.security_tool.x86_64-darwin
darwin.shell_cmds.x86_64-darwin
darwin.swift-corefoundation.x86_64-linux
darwin.xnu.x86_64-linux
emacs25Macport.x86_64-darwin
emacs25Macport_25_1.x86_64-darwin
emacsMacport.x86_64-darwin
gtk-mac-bundler.x86_64-darwin
gtk-mac-integration.x86_64-darwin
gtk-mac-integration-gtk3.x86_64-darwin
haskellPackages.hfsevents.x86_64-darwin
iterm2.x86_64-darwin
khd.x86_64-darwin
kwm.x86_64-darwin
macvim.x86_64-darwin
pinentry_mac.x86_64-darwin
qt5.qtmacextras.x86_64-darwin
qt58.qtmacextras.x86_64-darwin
quartz-wm.x86_64-darwin
reattach-to-user-namespace.x86_64-darwin
sbagen.i686-linux
sequelpro.x86_64-darwin
smlnjBootstrap.x86_64-darwin
stalin.i686-linux
sudolikeaboss.x86_64-darwin
terminal-notifier.x86_64-darwin
ubootRaspberryPi3_64bit.aarch64-linux
wxmac.x86_64-darwin
xhyve.x86_64-darwin
xquartz.x86_64-darwin

Sounds like some of the Darwin.* need meta attributes first.

@Ericson2314
Copy link
Member

We should change the fallback for no meta in release-lib to include all of supported systems. Then we only need to worry about the case where the meta is explicitly darwin only.

@matthewbauer
Copy link
Member

We should change the fallback for no meta in release-lib to include all of supported systems

Most packages without meta are probably not very well maintained. I think making people put these in is probably good in pushing people to think about other platforms than their own.

@LnL7
Copy link
Member Author

LnL7 commented May 23, 2017

@dezgeg That looks like an acceptable workaround until we have #22277. 😄

@Ericson2314
Copy link
Member

@matthewbauer err are we agreeing :)? I'd think the more optimistic the default is, the more obvious any failures will be so it doesn't slip through the cracks.

@matthewbauer
Copy link
Member

I'd think the more optimistic the default is, the more obvious any failures will be so it doesn't slip through the cracks.

Yeah I guess I don't feel that strongly either way. My big concern was just the build farm running things it doesn't need to - but either way sounds fine.

@matthewbauer
Copy link
Member

@Ericson2314 @LnL7 Can this be merged now? it would definitely make things easier to track Darwin-specific jobs. #26774

@LnL7
Copy link
Member Author

LnL7 commented Jun 23, 2017

I think @dezgeg's solution is a lot better.

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 23, 2017

@matthiasbeyer you just have Darwin derivations, not derivations missing meta on the list, right? Then sounds good to me.

@matthewbauer
Copy link
Member

Yeah if they were missing meta, I could just fix them on my own. With Darwin-only we're kind of stuck.

@Ericson2314
Copy link
Member

Ah sorry, I forgot you couldn't merge this yourself. I'll gladly merge once the conflict is fixed.

@LnL7
Copy link
Member Author

LnL7 commented Aug 17, 2017

Closing in favour of #28174.

@LnL7 LnL7 closed this Aug 17, 2017
@LnL7 LnL7 deleted the darwin-hydra-jobs branch August 17, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Put apple-source-releases in Hydra

5 participants