bootstrap-tools-cross: Rename bootstrap file jobs to be more descriptive #258540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
commented
Oct 2, 2023
Member
Author
There was a problem hiding this comment.
Removed the -gnu because it does not seem significant
ofborg
bot
added
the
6.topic: cross-compilation
13 tasks
Member
|
@ofborg eval |
Member
I would much prefer we always use a full triple, e.g. |
ofborg
bot
added
10.rebuild-darwin: 0
Artturin
force-pushed
the
renamebootstrapfiles
branch
2 times, most recently
from
31593ee to
83f9d40
Compare
Rename files in `bootstrap-files/` to match jobs in `make-bootstrap-tools-cross`.
Should make automating the bootstrap files easier.
```nix
$ nix repl --file ./pkgs/top-level/release-cross.nix
nix-repl> bootstrapTools
{ aarch64-unknown-linux-gnu = { ... }; aarch64-unknown-linux-musl = { ... }; armv5tel-unknown-linux-gnueabi = { ... }; armv6l-unknown-linux-gnueabihf = { ... }; armv6l-unknown-linux-musleabihf = { ... }; armv7l-unknown-linux-gnueabihf = { ... }; mips64el-unknown-linux-gnuabi64 = {... }; mips64el-unknown-linux-gnuabin32 = { ... }; mipsel-unknown-linux-gnu = { ... }; powerpc64le-unknown-linux-gnu = { ... }; riscv64-unknown-linux-gnu = { ... }; x86_64-unknown-linux-musl = { ... }; }
```
Additionally if non-linux bootstrap files are added to
`make-bootstrap-tools-cross` then there won't be any renaming needed.
Artturin
force-pushed
the
renamebootstrapfiles
branch
from
83f9d40 to
1270ef5
Compare
Ericson2314
approved these changes
Oct 3, 2023
delroth
added
the
12.approvals: 2
ghost
reviewed
Oct 20, 2023
| else ./bootstrap-files/mips64el.nix); | ||
| powerpc64le-linux = import ./bootstrap-files/powerpc64le.nix; | ||
| riscv64-linux = import ./bootstrap-files/riscv64.nix; | ||
| then ./bootstrap-files/mips64el-unknown-linux-gnuabin32.nix.nix |
There was a problem hiding this comment.
Suggested change
| then ./bootstrap-files/mips64el-unknown-linux-gnuabin32.nix.nix | |
| then ./bootstrap-files/mips64el-unknown-linux-gnuabin32.nix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename files in
bootstrap-files/to match jobs inmake-bootstrap-tools-cross.Should make automating the bootstrap files easier.
Additionally if non-linux bootstrap files are added to
make-bootstrap-tools-crossthen there won't be any renaming needed.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)