Skip to content

mermaid-cli: use fetchYarnDeps#258517

Merged
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:mermaid-cli-fetchYarnDeps
Oct 3, 2023
Merged

mermaid-cli: use fetchYarnDeps#258517
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:mermaid-cli-fetchYarnDeps

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 2, 2023

Description of changes

see #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cc @ysndr who originally packaged it in #87766

@github-actions github-actions bot added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label Oct 2, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 2, 2023
@ofborg ofborg bot requested a review from ysndr October 2, 2023 04:18
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 2, 2023
@cafkafk
Copy link
Member

cafkafk commented Oct 2, 2023

Result of nixpkgs-review pr 258517 run on x86_64-linux 1

1 package built:
  • mermaid-cli

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 2, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 2, 2023
@dotlambda dotlambda force-pushed the mermaid-cli-fetchYarnDeps branch from ff4af3d to 47498e6 Compare October 2, 2023 15:48
@delroth delroth removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Oct 2, 2023
@dotlambda dotlambda force-pushed the mermaid-cli-fetchYarnDeps branch from 47498e6 to 7afc82b Compare October 2, 2023 19:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 2, 2023
@dotlambda dotlambda force-pushed the mermaid-cli-fetchYarnDeps branch from 7afc82b to 2e43e13 Compare October 2, 2023 21:10
@ofborg ofborg bot requested a review from Luflosi October 2, 2023 21:51
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 2, 2023
@dotlambda
Copy link
Member Author

dotlambda commented Oct 2, 2023

Result of nixpkgs-review pr 258517 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • code-server
  • mx-puppet-discord
45 packages built:
  • balena-cli
  • coder
  • commitlint
  • create-cycle-app
  • emacsPackages.lsp-bridge
  • fast-cli
  • graphite-cli
  • jellyseerr
  • joplin
  • lemmy-ui
  • lessc
  • lighthouse
  • lv_img_conv
  • mastodon-bot
  • mermaid-cli
  • n8n
  • nodehun
  • pgrok
  • pgrok.server
  • pm2
  • postcss-cli
  • pot
  • pscid
  • pyright
  • snyk
  • styx
  • styx.lib
  • styx.themes
  • theLoungePlugins.plugins.closepms
  • theLoungePlugins.plugins.giphy
  • theLoungePlugins.themes.flat-blue
  • theLoungePlugins.themes.flat-dark
  • uppy-companion
  • vimPlugins.coc-docker
  • vimPlugins.coc-emmet
  • vimPlugins.coc-go
  • vimPlugins.coc-markdownlint
  • vimPlugins.coc-metals
  • vimPlugins.coc-pyright
  • vimPlugins.coc-r-lsp
  • vimPlugins.coc-snippets
  • vimPlugins.coc-stylelint
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.rust-lang.rust-analyzer
  • wrangler

@dotlambda dotlambda merged commit 4c3e787 into NixOS:master Oct 3, 2023
@dotlambda dotlambda deleted the mermaid-cli-fetchYarnDeps branch October 3, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

@cafkafk cafkafk cafkafk approved these changes

@ysndr ysndr Awaiting requested review from ysndr

@Luflosi Luflosi Awaiting requested review from Luflosi

Assignees

No one assigned

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @cafkafk @teto @delroth