Merged
Conversation
kashw2
suggested changes
Sep 27, 2023
Contributor
|
nitpick, but could we amend the last commit to be |
Contributor
|
Result of 1 package built:
|
Contributor
Author
Done |
kashw2
approved these changes
Sep 29, 2023
Contributor
kashw2
left a comment
There was a problem hiding this comment.
LGTM, Thanks a bunch for this
Contributor
Author
|
Do I need to ping someone to move this forward? |
Contributor
Author
|
They had two releases with significant new features since I opened this PR 🤣 Daaaam |
kashw2
approved these changes
Sep 30, 2023
Contributor
Nah, someone with commit access will come along and merge it if they don't have any suggestions eventually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Version change
Turso CLI doesn't include a changelog, but the commits since the version here are there:
tursodatabase/turso-cli@v0.82.0...v0.85.3
The major changes are:
Other changes
preBuildstep to inform the build which version is being built (would be generated from the git tag)Previously
turso --versionwould showturso version dev.Now it shows
turso version v0.85.1 (nix build). I added the(nix build)at the end to avoid confusion with their distributed binaries.meta.mainProgramto allownix run nixpkgs#turso-clito workThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)