Skip to content

turso-cli: 0.82.0 -> 0.85.3#257627

Merged
wegank merged 4 commits intoNixOS:masterfrom
Fryuni:turso
Oct 2, 2023
Merged

turso-cli: 0.82.0 -> 0.85.3#257627
wegank merged 4 commits intoNixOS:masterfrom
Fryuni:turso

Conversation

@Fryuni
Copy link
Contributor

@Fryuni Fryuni commented Sep 27, 2023

Description of changes

Version change

Turso CLI doesn't include a changelog, but the commits since the version here are there:
tursodatabase/turso-cli@v0.82.0...v0.85.3

The major changes are:

  • Support for database groups, allowing hundreds of isolated databases in a single location.
  • Data branching.
  • Point in time recovery.

Other changes

  • Added the build tag "prod" to mirror their release builds and not include development code
  • Added a preBuild step to inform the build which version is being built (would be generated from the git tag)
    Previously turso --version would show turso version dev.
    Now it shows turso version v0.85.1 (nix build). I added the (nix build) at the end to avoid confusion with their distributed binaries.
  • Added meta.mainProgram to allow nix run nixpkgs#turso-cli to work

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kashw2 September 27, 2023 12:02
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 27, 2023
@Fryuni Fryuni requested a review from kashw2 September 28, 2023 20:47
@kashw2
Copy link
Contributor

kashw2 commented Sep 28, 2023

nitpick, but could we amend the last commit to be turso-cli: remove nix from version tag?

@kashw2
Copy link
Contributor

kashw2 commented Sep 28, 2023

Result of nixpkgs-review pr 257627 run on x86_64-linux 1

1 package built:
  • turso-cli

@Fryuni
Copy link
Contributor Author

Fryuni commented Sep 29, 2023

nitpick, but could we amend the last commit to be turso-cli: remove nix from version tag?

Done

Copy link
Contributor

@kashw2 kashw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a bunch for this

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 29, 2023
@Fryuni
Copy link
Contributor Author

Fryuni commented Sep 29, 2023

Do I need to ping someone to move this forward?

@Fryuni Fryuni changed the title turso-cli: 0.82.0 -> 0.85.1 turso-cli: 0.82.0 -> 0.85.3 Sep 29, 2023
@Fryuni
Copy link
Contributor Author

Fryuni commented Sep 29, 2023

They had two releases with significant new features since I opened this PR 🤣

Daaaam

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 29, 2023
@ofborg ofborg bot requested a review from kashw2 September 29, 2023 18:58
@kashw2
Copy link
Contributor

kashw2 commented Sep 30, 2023

Do I need to ping someone to move this forward?

Nah, someone with commit access will come along and merge it if they don't have any suggestions eventually

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 30, 2023
@wegank wegank merged commit f0a8d61 into NixOS:master Oct 2, 2023
@Fryuni Fryuni deleted the turso branch October 2, 2023 11:50
@Fryuni Fryuni mentioned this pull request Oct 18, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants