rust-hypervisor-firmware: fix build#257345
Merged
yu-re-ka merged 2 commits intoNixOS:masterfrom Sep 26, 2023
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
@ofborg build rust-hypervisor-firmware |
Contributor
|
What broke this was not the rust 1.72.0 bump, but #176694. |
yu-re-ka
approved these changes
Sep 26, 2023
delroth
added
the
12.approvals: 1
flokli
reviewed
Sep 26, 2023
yu-re-ka
reviewed
Sep 26, 2023
Co-authored-by: Yureka <yuka@yuka.dev>
delroth
removed
the
12.approvals: 1
flokli
approved these changes
Sep 26, 2023
13 tasks
13 tasks
alyssais
added a commit
to alyssais/nixpkgs
that referenced
this pull request
Dec 17, 2023
This reverts commit e97f8fe. No longer necessary since the rustc wrapper now handles --sysroot correctly.
alyssais
added a commit
that referenced
this pull request
Dec 19, 2023
This reverts commit e97f8fe. No longer necessary since the rustc wrapper now handles --sysroot correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix #256957
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)