Skip to content

pgadmin4: 7.5 -> 7.7#257119

Merged
yayayayaka merged 2 commits intoNixOS:masterfrom
gador:pgadmin-7.7
Oct 20, 2023
Merged

pgadmin4: 7.5 -> 7.7#257119
yayayayaka merged 2 commits intoNixOS:masterfrom
gador:pgadmin-7.7

Conversation

@gador
Copy link
Member

@gador gador commented Sep 24, 2023

Description of changes

Update of pgadmin4. Changelog: https://www.pgadmin.org/docs/pgadmin4/latest/release_notes_7_7.html

Includes a security fix: CVE-2023-5002

This PR includes the update from pgadmin 7.5 -> 7.6 (see #251936 for an in depth description)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@gador
pgadmin4: 7.5 -> 7.6
ff8bed4 
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@gador gador mentioned this pull request Sep 24, 2023
Closed
12 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 24, 2023
@nixos-discourse
Copy link

nixos-discourse commented Sep 27, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2691

SuperSandro2000
SuperSandro2000 approved these changes Sep 27, 2023
View reviewed changes
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 27, 2023
@gador
pgadmin4: 7.6 -> 7.7
8e2e243 
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@gador
Copy link
Member Author

gador commented Sep 28, 2023

@SuperSandro2000 done 👍

@delroth delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 28, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 28, 2023
@nixos-discourse
Copy link

nixos-discourse commented Oct 8, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1147

@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 14, 2023
@LeSuisse LeSuisse changed the title Pgadmin 7.7 pgadmin4: 7.5 -> 7.7 Oct 14, 2023
@nixos-discourse
Copy link

nixos-discourse commented Oct 20, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1175

@yayayayaka
Copy link
Member

yayayayaka commented Oct 20, 2023

Result of nixpkgs-review pr 257119 run on x86_64-linux 1

4 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist

yayayayaka
yayayayaka approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though pgadmin 7.8 has been released yesterday, I am going to merge this anyway to get the security fix in.

@yayayayaka yayayayaka merged commit be90db7 into NixOS:master Oct 20, 2023
@gador
Copy link
Member Author

gador commented Oct 20, 2023

@yayayayaka thanks. I'll check out 7.8 in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@wegank wegank Awaiting requested review from wegank

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gador @nixos-discourse @yayayayaka @SuperSandro2000 @delroth @LeSuisse