python3Packages.fluent-pygments: init at 1.0 by GetPsyched · Pull Request #255937 · NixOS/nixpkgs

GetPsyched · 2023-09-18T17:45:35Z

Description of changes

Project Fluent is a localisation system. python-fluent is its Python implementation.

This PR adds all 3 of its Python packages:

fluent-syntax
fluent-runtime
fluent-pygments

Things done

GetPsyched · 2023-09-18T17:48:40Z

I apologise for the non-standard PR in terms of the PR name and not having a default.nix file. The reason for both is the same: this PR adds multiple packages of the same project. One of the packages depends on the other, so, I had to merge them in a single PR. Please let me know if there is something else I could have done. (I couldn't find any contributing guidelines for a scenario like this one)

pkgs/development/python-modules/python-fluent/fluent-pygments.nix

pkgs/development/python-modules/python-fluent/fluent-runtime.nix

GetPsyched · 2023-09-25T03:05:18Z

Hey, @fabaff! Thanks for the review. Just tested the changes on my project locally. Everything seems to be working fine.

GetPsyched · 2023-10-11T13:41:54Z

Awaiting further review.

GetPsyched · 2024-06-02T18:40:52Z

How do I reload the ofborg test? It seems like the error was that ofborg ran out of memory.

Aleksanaa

Looks good, just some recent changes in Nixpkgs need to be changed accordingly

pkgs/development/python-modules/python-fluent/fluent-pygments.nix

erictapen

Just noticed that fluent-pygments fails currently:

python3.11-fluent-pygments> Running phase: setuptoolsCheckPhase                                                                                                                                                       
python3.11-fluent-pygments> Executing setuptoolsCheckPhase                                                                                                                                                            
python3.11-fluent-pygments> running test                                                                                                                                                                              
python3.11-fluent-pygments> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
.                                                                                                                                                                                                                     
python3.11-fluent-pygments> /nix/store/9ryla5qrjhmb3nix3cp0n57qx06scgc0-python3.11-setuptools-69.5.1/lib/python3.11/site-packages/setuptools/command/test.py:193: _DeprecatedInstaller: setuptools.installer and fetch
_build_eggs are deprecated.                                                                                                                                                                                           
python3.11-fluent-pygments> !!                                                                                                                                                                                        
python3.11-fluent-pygments>         ********************************************************************************                                                                                                  
python3.11-fluent-pygments>         Requirements should be satisfied by a PEP 517 installer.                                                                                                                          
python3.11-fluent-pygments>         If you are using pip, you can try `pip install --use-pep517`.                                                                                                                     
python3.11-fluent-pygments>         ********************************************************************************
python3.11-fluent-pygments> !!                       
python3.11-fluent-pygments>   ir_d = dist.fetch_build_eggs(dist.install_requires)                          
python3.11-fluent-pygments> /nix/store/6b1fqdwb3g56j5pazv8zkx9qd0mv3wiz-python3-3.11.9/bin/python3.11: No module named pip
python3.11-fluent-pygments> error: Command '['/nix/store/6b1fqdwb3g56j5pazv8zkx9qd0mv3wiz-python3-3.11.9/bin/python3.11', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/build/tmpw4bqqroj'
, '--quiet', 'six']' returned non-zero exit status 1.

GetPsyched · 2024-07-03T06:35:46Z

Wow, can't believe I missed that; and so did ofborg for some reason. Fixed it, thanks!

pkgs/development/python-modules/python-fluent/fluent-pygments.nix

pkgs/development/python-modules/python-fluent/fluent-runtime.nix

pkgs/development/python-modules/python-fluent/fluent-syntax.nix

pkgs/development/python-modules/python-fluent/fluent-runtime.nix

pkgs/development/python-modules/python-fluent/fluent-pygments.nix

erictapen

Looks good and builds for me. Is there anything else blocking this?

erictapen · 2024-07-16T12:16:00Z

@GrahamcOfBorg build python3Packages.fluent-syntax python3Packages.fluent-runtime python3Packages.fluent-pygments

GetPsyched · 2024-07-16T12:27:01Z

No blockers from my end.

pkgs/development/python-modules/python-fluent/fluent-syntax.nix

logs/atlauncher.log

erictapen · 2024-07-17T10:45:31Z

@GrahamcOfBorg build python3Packages.fluent-syntax python3Packages.fluent-runtime python3Packages.fluent-pygments

erictapen

There is now a test failure for fluent-runtime:

python3.12-fluent-runtime> =================================== FAILURES ===================================
python3.12-fluent-runtime> _________________________ TestFluentDate.test_timeZone _________________________
python3.12-fluent-runtime> self = <tests.test_types.TestFluentDate testMethod=test_timeZone>
python3.12-fluent-runtime>     def test_timeZone(self):
python3.12-fluent-runtime>         en_GB = Locale.parse('en_GB')
python3.12-fluent-runtime>         LondonTZ = pytz.timezone('Europe/London')
python3.12-fluent-runtime>         # 1st July is a date in British Summer Time
python3.12-fluent-runtime>         # datetime object with tzinfo set to BST
python3.12-fluent-runtime>         dt1 = datetime(2018, 7, 1, 23, 30, 0, tzinfo=pytz.UTC).astimezone(LondonTZ)
python3.12-fluent-runtime>         fd1 = fluent_date(dt1, dateStyle='short', timeStyle='short')
python3.12-fluent-runtime>         self.assertEqual(fd1.format(en_GB), '02/07/2018, 00:30')
python3.12-fluent-runtime>         fd1b = fluent_date(dt1, dateStyle='full', timeStyle='full')
python3.12-fluent-runtime> >       self.assertRegex(fd1b.format(en_GB), '^Monday, 2 July 2018(,| at) 00:30:00 British Summer Time$')
python3.12-fluent-runtime> E       AssertionError: Regex didn't match: '^Monday, 2 July 2018(,| at) 00:30:00 British Summer Time$' not found in 'Monday 2 July 2018, 00:30:00 British Summer Time'
python3.12-fluent-runtime> tests/test_types.py:249: AssertionError
python3.12-fluent-runtime> =============================== warnings summary ===============================
python3.12-fluent-runtime> tests/test_types.py::TestFluentDate::test_copy_attributes
python3.12-fluent-runtime>   /build/source/fluent.runtime/fluent/runtime/types.py:308: UserWarning: FluentDateType option hour12 is not yet supported
python3.12-fluent-runtime>     warnings.warn(f"FluentDateType option {k} is not yet supported")
python3.12-fluent-runtime> -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
python3.12-fluent-runtime> =========================== short test summary info ============================
python3.12-fluent-runtime> FAILED tests/test_types.py::TestFluentDate::test_timeZone - AssertionError: Regex didn't match: '^Monday, 2 July 2018(,| at) 00:30:00 B...
python3.12-fluent-runtime> ============= 1 failed, 179 passed, 1 skipped, 1 warning in 0.31s ==============
python3.12-fluent-runtime> /nix/store/5r0df66ikad3xw06azlqvswcvncll8wa-stdenv-linux/setup: line 1641: pop_var_context: head of shell_variables not a function context

erictapen · 2024-07-17T19:54:29Z

Looks like this PR would fix the test failure: projectfluent/python-fluent#203

GetPsyched · 2024-07-18T06:08:55Z

Interesting, it didn't fail when I made the commit, but it does now.

I tried adding a patch using fetchpatch but got some parsing error. I don't want to add the patch to the repo itself so I've disabled the test with the PR in a comment.

erictapen · 2024-07-18T10:52:57Z

@GrahamcOfBorg build python3Packages.fluent-syntax python3Packages.fluent-runtime python3Packages.fluent-pygments

erictapen

LGTM again!

erictapen · 2024-07-19T09:57:47Z

@SuperSandro2000 can you unblock the PR/give it another look?

addressed

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 18, 2023

GetPsyched mentioned this pull request Sep 19, 2023

No release for fluent.runtime 0.4.0 projectfluent/python-fluent#187

Closed

fabaff reviewed Sep 23, 2023

View reviewed changes

GetPsyched force-pushed the python-fluent branch from 6747a92 to d31d372 Compare September 25, 2023 02:57

GetPsyched requested a review from fabaff October 1, 2023 17:02

GetPsyched force-pushed the python-fluent branch 2 times, most recently from 6447812 to f9c4290 Compare December 30, 2023 18:38

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024

Sigmanificient added 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers and removed 0.kind: package adoption Requests or PRs for adopting packages that have no maintainers labels May 13, 2024

GetPsyched force-pushed the python-fluent branch from f9c4290 to a7a2dc6 Compare May 20, 2024 19:05

GetPsyched removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 20, 2024

GetPsyched force-pushed the python-fluent branch from a7a2dc6 to a6aee98 Compare June 28, 2024 21:07

Aleksanaa reviewed Jun 29, 2024

View reviewed changes

GetPsyched force-pushed the python-fluent branch from a6aee98 to f49aa3c Compare June 29, 2024 09:12

erictapen approved these changes Jul 2, 2024

View reviewed changes

erictapen requested changes Jul 2, 2024

View reviewed changes

GetPsyched force-pushed the python-fluent branch from f49aa3c to 6344d47 Compare July 3, 2024 06:35

erictapen approved these changes Jul 3, 2024

View reviewed changes

GetPsyched mentioned this pull request Jul 8, 2024

weblate: init at 5.6.2, add module #325541

Merged

13 tasks

SuperSandro2000 changed the title ~~python-fluent: init~~ python3Packages.fluent-pygments: init at 1.0 Jul 8, 2024

SuperSandro2000 reviewed Jul 8, 2024

View reviewed changes

GetPsyched force-pushed the python-fluent branch from 6344d47 to 4ede488 Compare July 8, 2024 15:56

GetPsyched requested a review from natsukium as a code owner July 8, 2024 15:56

GetPsyched force-pushed the python-fluent branch from 4ede488 to e315643 Compare July 9, 2024 14:12

GetPsyched requested a review from SuperSandro2000 July 9, 2024 14:13

erictapen approved these changes Jul 16, 2024

View reviewed changes

natsukium reviewed Jul 16, 2024

View reviewed changes

pkgs/development/python-modules/python-fluent/fluent-syntax.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/python-fluent/fluent-syntax.nix Outdated Show resolved Hide resolved

GetPsyched force-pushed the python-fluent branch from e315643 to 5eaae5c Compare July 16, 2024 17:00

SuperSandro2000 previously requested changes Jul 16, 2024

View reviewed changes

logs/atlauncher.log Outdated Show resolved Hide resolved

python3Packages.fluent-syntax: init at 0.19.0

b50049c

GetPsyched force-pushed the python-fluent branch from 5eaae5c to a74627a Compare July 17, 2024 08:35

erictapen requested changes Jul 17, 2024

View reviewed changes

GetPsyched added 2 commits July 18, 2024 10:08

python3Packages.fluent-runtime: init at 0.4.0

feab5ab

python3Packages.fluent-pygments: init at 1.0

0f861fa

GetPsyched force-pushed the python-fluent branch from a74627a to 0f861fa Compare July 18, 2024 06:09

erictapen approved these changes Jul 18, 2024

View reviewed changes

SuperSandro2000 merged commit aa70ff8 into NixOS:master Jul 19, 2024

Uh oh!

Conversation

GetPsyched commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Things done

Uh oh!

GetPsyched commented Sep 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GetPsyched commented Sep 25, 2023

Uh oh!

GetPsyched commented Oct 11, 2023

Uh oh!

GetPsyched commented Jun 2, 2024

Uh oh!

Aleksanaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erictapen left a comment

Choose a reason for hiding this comment

Uh oh!

GetPsyched commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erictapen left a comment

Choose a reason for hiding this comment

Uh oh!

erictapen commented Jul 16, 2024

Uh oh!

GetPsyched commented Jul 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erictapen commented Jul 17, 2024

Uh oh!

erictapen left a comment

Choose a reason for hiding this comment

Uh oh!

erictapen commented Jul 17, 2024

Uh oh!

GetPsyched commented Jul 18, 2024

Uh oh!

erictapen commented Jul 18, 2024

Uh oh!

erictapen left a comment

Choose a reason for hiding this comment

Uh oh!

erictapen commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GetPsyched commented Sep 18, 2023 •

edited

Loading