Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 501+
Member
|
@NixOS/darwin-maintainers is |
Member
|
Member
|
Looks promising, thanks! |
Member
|
@ofborg build libsodium libsodium.passthru.tests |
wegank
approved these changes
Sep 20, 2023
delroth
added
the
12.approvals: 1
vcunat
added a commit
that referenced
this pull request
Oct 8, 2023
This reverts commit 16ed72e, reversing changes made to 8530ff3. -Ofast in default flags sounds like a bad idea, and it also breaks some of our builds. Upstream: jedisct1/libsodium@ad4584d45#commitcomment-129441988 - I see no change that we'd need to have now: https://github.com/jedisct1/libsodium/blob/1.0.19/ChangeLog
Member
|
Reverted for now after some discussion in https://matrix.to/#/#staging:nixos.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/libsodium/versions.
meta.description for libsodium is: A modern and easy-to-use crypto library
meta.homepage for libsodium is: http://doc.libsodium.org/
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
NixPkgs review skipped
Maintainer pings
cc @7c6f434c for testing.