python3.pkgs.pypaBuildHook: fix conflicts via propagated inputs#254547
Merged
Lassulus merged 1 commit intoNixOS:stagingfrom Sep 15, 2023
Merged
python3.pkgs.pypaBuildHook: fix conflicts via propagated inputs#254547Lassulus merged 1 commit intoNixOS:stagingfrom
Lassulus merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
DavHau
force-pushed
the
fix-pyproject-build
branch
from
ff22f11 to
00cbe60
Compare
This modifies the pypaBuildHook to not propagate its own python dependencies into the build environment. This prevents package conflicts. - modify pypa-build-hook.sh to call pyproject-build via an absolute path. This removes the need of putting the dependencies inside the hook's propagatedBuildInputs - remove the hook's dependencies from propagatedBuildInputs - add a passthru test to the hook testing for the fix
DavHau
force-pushed
the
fix-pyproject-build
branch
from
00cbe60 to
c57e6b6
Compare
Member
|
cc @figsoda |
SuperSandro2000
approved these changes
Sep 14, 2023
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
I didn't deeply think about this but it does look good
FRidh
approved these changes
Sep 14, 2023
delroth
added
the
12.approvals: 2
13 tasks
DavHau
added a commit
to DavHau/nixpkgs
that referenced
this pull request
Jan 8, 2024
A follow up on NixOS#254547 As of now the hook still propagated `wheel` into the build environment which lead to a collision error as soon as any other version of wheel gets introduced as a dependency. This makes the nixpkgs python infra more suitable for use with dynamic dependency versions like generated by 2nix tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This modifies the pypaBuildHook to not propagate its own python dependencies into the build environment. This prevents package conflicts in downstream projects whenever a package is built against other versions of the dependencies of the hook.
This problem was likely introduced by #248866
Done:
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)