haskellPackages.git-brunch: unbreak

[andys8]

Description of changes

• Updated git-brunch itself to work with newer GHC versions
• https://hackage.haskell.org/package/git-brunch-1.7.2.0
• https://github.com/andys8/git-brunch/releases/tag/v1.7.2
• https://github.com/andys8/git-brunch/actions/runs/6137043306

Things not done

This PR will not update haskell-packages. Therefore the version is still < 1.7.2 until hackage updates are reflected.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[cdepillabout]

@andys8 Thanks for putting together this PR.

Just to be clear, this requires the hackage pin in Nixpkgs to be updated before git-brunch is expected to be working, right? (So #249708 will have to be merged in, and then the follow-up haskell-updates PR will have to be open.) Please make sure to ping us (or just me) to merge this in after the next PR is open if we forget.

Also, can you make sure to change the PR title and commit message to adhere to https://github.com/NixOS/nixpkgs/blob/688d95b6e6c1a1a0fb91be7b80bff228b20c8024/CONTRIBUTING.md#commit-conventions ?

[andys8]

Thanks for letting me know. The pull request title and commit message are changed, now :)

Just to be clear, this requires the hackage pin in Nixpkgs to be updated before git-brunch is expected to be working, right?

Correct, I released v1.7.2 just today to hackage.

[cdepillabout]

@andys8 Thanks for releasing the new version.

It looks like git-brunch now builds on haskell-updates, so I've marked it unbroken in commit d9cc849, which I've just pushed to #262645.

Also, I'd suggest you send a PR adding yourself as a maintainer for git-brunch if you'd like to see it always working in Nixpkgs. We have a semi-automated system setup to ping maintainers when their packages stop building if they add themselves as maintainers:

nixpkgs/pkgs/development/haskell-modules/configuration-hackage2nix/main.yaml

Lines 148 to 169 in 04ba740

	package-maintainers:
	abbradar:
	- Agda
	Anton-Latukha:
	- hnix
	- hnix-store-core
	- hnix-store-remote
	arturcygan:
	- hevm
	berberman:
	- nvfetcher
	- arch-web
	- uusi
	bdesham:
	- pinboard-notes-backup
	cdepillabout:
	- password
	- password-instances
	- pretty-simple
	- stack
	- termonad
	centromere:

I'll go ahead and close this.