Skip to content

android.env.buildGradleApp: Reinit#254082

Closed
Artturin wants to merge 2 commits intoNixOS:masterfrom
Artturin:readdgradleapp
Closed

android.env.buildGradleApp: Reinit#254082
Artturin wants to merge 2 commits intoNixOS:masterfrom
Artturin:readdgradleapp

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Sep 8, 2023

Was removed in a27aa24

it's PR 50596 had "Readd androidenv.buildGradleApp" in "Still to do:" in its description.

copied from https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/build-gradle-app.nix

Which is where the original buildGradleApp came from in PR 41855.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

This was referenced Sep 8, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/using-androidenv-error-functionargs-requires-a-function/32773/6

@Artturin Artturin force-pushed the readdgradleapp branch 2 times, most recently from e81f009 to 169e6d8 Compare September 8, 2023 19:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 8, 2023
Was removed in a27aa24

it's PR 50596 had "Readd androidenv.buildGradleApp" in "Still to do:" in its
description.

Directly copied without changes from https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/build-gradle-app.nix

Which is where the original buildGradleApp came from in PR 41855.

Check https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/impl.nix for a bit more info on usage
@Artturin
Copy link
Member Author

Artturin commented Sep 8, 2023

I really don't know how this is supposed to be used.

I tried

{ pkgs ? import ./. { config = { android_sdk.accept_license = true; }; } }:

pkgs.androidenv.buildGradleApp {
  name = "test";

  gradleTask = "build";

  src = pkgs.fetchFromGitHub {
    owner = "mikevoxcap";
    repo = "gradle-hello-world";
    rev = "308e8972c2bcd0ad1b306ee32786489db74628e7";
    hash = "sha256-jKKIZf+WDz3cGKaHj45/N8SbkfKwnJtp9KhQvlqcEyY=";
  };

  #src = pkgs.fetchFromGitHub {
  #  owner = "jabedhasan21";
  #  repo = "java-hello-world-with-gradle";
  #  rev = "f5eab08edf1ec9e1b8e15f032afe42216400433d";
  #  hash = "sha256-XUkuRya9hXYVFm3p9KalLRmCUL61H/YyWswd+jIXnSI=";
  #};
}

and both src fail

https://github.com/search?q=gradleTask+%3D+language%3Anix&type=code

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@Artturin Artturin closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants