android.env.buildGradleApp: Reinit#254082
Closed
Artturin wants to merge 2 commits intoNixOS:masterfrom
Closed
Conversation
This was referenced Sep 8, 2023
Merged
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/using-androidenv-error-functionargs-requires-a-function/32773/6 |
e81f009 to
169e6d8
Compare
Was removed in a27aa24 it's PR 50596 had "Readd androidenv.buildGradleApp" in "Still to do:" in its description. Directly copied without changes from https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/build-gradle-app.nix Which is where the original buildGradleApp came from in PR 41855. Check https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/impl.nix for a bit more info on usage
169e6d8 to
0180217
Compare
0180217 to
cb59cd9
Compare
Member
Author
|
I really don't know how this is supposed to be used. I tried { pkgs ? import ./. { config = { android_sdk.accept_license = true; }; } }:
pkgs.androidenv.buildGradleApp {
name = "test";
gradleTask = "build";
src = pkgs.fetchFromGitHub {
owner = "mikevoxcap";
repo = "gradle-hello-world";
rev = "308e8972c2bcd0ad1b306ee32786489db74628e7";
hash = "sha256-jKKIZf+WDz3cGKaHj45/N8SbkfKwnJtp9KhQvlqcEyY=";
};
#src = pkgs.fetchFromGitHub {
# owner = "jabedhasan21";
# repo = "java-hello-world-with-gradle";
# rev = "f5eab08edf1ec9e1b8e15f032afe42216400433d";
# hash = "sha256-XUkuRya9hXYVFm3p9KalLRmCUL61H/YyWswd+jIXnSI=";
#};
}and both src fail https://github.com/search?q=gradleTask+%3D+language%3Anix&type=code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was removed in a27aa24
it's PR 50596 had "Readd androidenv.buildGradleApp" in "Still to do:" in its description.
copied from https://github.com/reflex-frp/reflex-platform/blob/bb2e06f1a327b79e91a0607ad9412422b25b4a32/android/build-gradle-app.nix
Which is where the original buildGradleApp came from in PR 41855.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)