Skip to content

lshw: fix withGUI compilation error#253768

Closed
dacioromero wants to merge 1 commit intoNixOS:masterfrom
dacioromero:lshw-gtk3
Closed

lshw: fix withGUI compilation error#253768
dacioromero wants to merge 1 commit intoNixOS:masterfrom
dacioromero:lshw-gtk3

Conversation

@dacioromero
Copy link
Contributor

Description of changes

Upgraded GTK to fix compilation error when compiled with withGUI = true.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 7, 2023
@dacioromero dacioromero changed the title lshw: switch to gtk3 for gui lshw: fix withGUI compilation error Dec 16, 2023
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@dacioromero
Copy link
Contributor Author

Fixed in #279592

@dacioromero dacioromero closed this Jun 6, 2024
@dacioromero dacioromero deleted the lshw-gtk3 branch June 6, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants