Skip to content

boinc: update to version 7.2.42, new nixos service#2526

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

boinc: update to version 7.2.42, new nixos service#2526
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented May 5, 2014

No description provided.

@bjornfor
Copy link
Contributor

Please add type declarations to the options (for inspiration, see other modules and lib/types.nix) and use 2 space per indent level (there are some 1 space indents there).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to have path = [ pkgs.boinc ]?

@bjornfor
Copy link
Contributor

Package bumps and adding new nixos modules are logically separate things. Please split into separate commits.

@bjornfor
Copy link
Contributor

You can update a pull request by running git rebase --interactive and force
push. As long as the subject is the same (more or less), no need to close
and create new pull.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant