python310Packages.heudiconv: patch out versioningit build dependency#252264
Closed
tjni wants to merge 1 commit intoNixOS:masterfrom
tjni:heudiconv
Closed
python310Packages.heudiconv: patch out versioningit build dependency#252264tjni wants to merge 1 commit intoNixOS:masterfrom tjni:heudiconv
tjni wants to merge 1 commit intoNixOS:masterfrom
tjni:heudiconv
Conversation
github-actions
bot
added
the
6.topic: python
12 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Janik-Haag
suggested changes
Aug 30, 2023
Contributor
|
Result of 4 packages built:
|
Janik-Haag
approved these changes
Sep 2, 2023
Member
|
Closed by #252799. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix the build after #248866 by patching out the versioningit build dependency. The package builds without it (it has a fallback in setup.py) and it's pinned to an old version of versioningit.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)