Skip to content

crossStdenv on iphone: Just get info from targetPlatform#25190

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:ios-stdenv-tiny-refactor
Apr 24, 2017
Merged

crossStdenv on iphone: Just get info from targetPlatform#25190
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:ios-stdenv-tiny-refactor

Conversation

@Ericson2314
Copy link
Member

Motivation for this change

Less indirection; Part of #25047

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from shlevy April 24, 2017 20:17
@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DavidEGrayson to be a potential reviewer.

@shlevy
Copy link
Member

shlevy commented Apr 24, 2017

LGTM if it works

@Ericson2314 Ericson2314 merged commit af6e4c5 into NixOS:master Apr 24, 2017
@Ericson2314 Ericson2314 deleted the ios-stdenv-tiny-refactor branch April 24, 2017 20:57
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants