Skip to content

openroad: unstable-2023-03-31 -> unstable-2023-08-26#251788

Closed
tobim wants to merge 1 commit intoNixOS:masterfrom
tobim:pkgs/openroad-2023-08-26
Closed

openroad: unstable-2023-03-31 -> unstable-2023-08-26#251788
tobim wants to merge 1 commit intoNixOS:masterfrom
tobim:pkgs/openroad-2023-08-26

Conversation

@tobim
Copy link
Contributor

@tobim tobim commented Aug 27, 2023

Description of changes

An update and extra fixes for building with fmt-10.1: The-OpenROAD-Project/OpenROAD#3911.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from trepetti August 27, 2023 15:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 27, 2023
@marsam marsam added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2023
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 11, 2023
@marsam
Copy link
Contributor

marsam commented Sep 13, 2023

Addressed by #250435

@marsam marsam closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants