python3Packages.pyssim: unbreak after recent pillow bump#251787
Merged
tjni merged 1 commit intoNixOS:masterfrom Aug 27, 2023
Merged
python3Packages.pyssim: unbreak after recent pillow bump#251787tjni merged 1 commit intoNixOS:masterfrom
tjni merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
@ofborg build python3Packages.pyssim sitespeed-io |
Contributor
|
This LGTM, thank you for the patch! I proposed it upstream in jterrace/pyssim#45. Could we pull the commit from there now? |
`Image.LANCZOS` is a drop-in replacement for `Image.ANTIALIAS`. See https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html#constants Pillow bump: bdf1a96 https://hydra.nixos.org/build/230653960 Co-authored-by: tjni <3806110+tjni@users.noreply.github.com>
emilylange
force-pushed
the
python3-pyssim
branch
from
b71788d to
ecae7dc
Compare
Member
Author
|
Thanks for raising a PR upstream! @ofborg build python3Packages.pyssim sitespeed-io |
tjni
approved these changes
Aug 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
pyssim, a dependency ofsitespeed-io, did break due to the recent pillow update as part of the usual python updates in staging.Caught when running
nixpkgs-reviewin #251400 (review)Image.LANCZOSis a drop-in replacement forImage.ANTIALIAS. See https://pillow.readthedocs.io/en/stable/releasenotes/10.0.0.html#constantsPillow bump: bdf1a96 (#244135)
https://hydra.nixos.org/build/230653960
If someone wants to upstream this patch, feel free to do so.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)