linux-wifi-hotspot: remove TKIP usage in create_ap

[ARizzo35]

Description of changes

Since TKIP is now deprecated in hostapd, the create_ap script in linux-wifi-hotspot needs to be updated to not use it.

Things done

Changes were built and tested on aarch64-linux.

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ARizzo35]

@onny

[Majiir]

What breaks when this patch isn't applied?

[Majiir]

nit: Why preBuild and not postPatch?

[oddlama]

What breaks when this patch isn't applied?

Most likely hostapd will not start. Since this is generally an issue with linux-wifi-hotspot I've opened lakinduakash/linux-wifi-hotspot#342 to track this upstream.

@ARizzo35 can you update this to use patches = [(fetchpatch {...})] to pull this in?

[ARizzo35]

What breaks when this patch isn't applied?

Most likely hostapd will not start. Since this is generally an issue with linux-wifi-hotspot I've opened lakinduakash/linux-wifi-hotspot#342 to track this upstream.

@ARizzo35 can you update this to use patches = [(fetchpatch {...})] to pull this in?

Yes, hostapd fails to start stating invalid cipher name 'TKIP CCMP'. I'll update this to use the upstream patch.

[ARizzo35]

       error: URL literals are disabled

       at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/os-specific/linux/linux-wifi-hotspot/default.nix:58:13:

           57|     (fetchpatch {
           58|       url = https://github.com/lakinduakash/linux-wifi-hotspot/commit/32fdb2bf2d3a34847270598682dec57cc3caf424.patch;
             |             ^
           59|       hash = "sha256-HUuJLOk7luQQ6xU5XKfGlV+YtLfYnFx2P6ZJF/1M7VE=";

@oddlama it looks like URL literals are disabled...should I add the patch as a file instead?

[Majiir]

@ARizzo35 Wrap the URL in double quotes so that it's a string literal rather than a URL literal.

[oddlama]

LGTM

[pbsds]

Result of nixpkgs-review pr 251191 run on x86_64-linux 1

1 package failed to build:

• linux-wifi-hotspot

linux-wifi-hotspot> building '/nix/store/p05aslisk861xkks609wwi8xmp8z2i7d-linux-wifi-hotspot-4.6.0.drv'
linux-wifi-hotspot> unpacking sources
linux-wifi-hotspot> unpacking source archive /nix/store/7frg7g8qxim5qckdzj8z8d7dadgrh76i-source
linux-wifi-hotspot> source root is source
linux-wifi-hotspot> patching sources
linux-wifi-hotspot> applying patch /nix/store/niz8il406j5nvrxfl38ijxivrl7zlxxc-32fdb2bf2d3a34847270598682dec57cc3caf424.patch
linux-wifi-hotspot> patching file src/scripts/create_ap
linux-wifi-hotspot> Reversed (or previously applied) patch detected!  Assume -R? [n] 
linux-wifi-hotspot> Apply anyway? [n] 
linux-wifi-hotspot> Skipping patch.
linux-wifi-hotspot> 1 out of 1 hunk ignored -- saving rejects to file src/scripts/create_ap.rej

[onny]

this might be already fixed upstream?

[pbsds]

Seems the patch was tagged in 4.6.0 which got merged in #266989