Relax or remove jupyterlab from some packages#250886
Merged
tjni merged 6 commits intoNixOS:staging-nextfrom Aug 24, 2023
tjni:jupyerlab
Merged
Relax or remove jupyterlab from some packages#250886tjni merged 6 commits intoNixOS:staging-nextfrom tjni:jupyerlab
tjni merged 6 commits intoNixOS:staging-nextfrom
tjni:jupyerlab
Conversation
github-actions
bot
added
the
6.topic: python
Contributor
Author
|
@ofborg build python310Packages.anywidget python311Packages.anywidget |
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
Author
|
Merging into staging-next since contributors are already finding these errors, and I'd like to make their lives easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Several packages declare in their pyproject.toml a dependency on jupyterlab v3. These builds now fail after #248866 due to stronger build dependency validation.
I'm pretty new to this ecosystem, so I did my best patching out the dependency when it seems unneeded and relaxing them when the build still seems to work.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)